Link inspector shows duplicate underscored title as first option
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jun 26 2019, 2:56 PM

Description

Parsoid always returns the link with underscores, even if it has spaces in the wikitext. We should use the normalised version with spaces and not show an extra match, which is missing an icon and description.

Details

	Subject	Repo	Branch	Lines +/-
	Fix link normalization when opening inspector	mediawiki/extensions/VisualEditor	master	+3 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ppelberg	T226645 Link inspector shows duplicate underscored title as first option
		Open		None	T225847 [minor] Multi-word links display underscores in the link inspector

Event Timeline

Esanders created this task.Jun 26 2019, 2:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2019, 2:56 PM

Esanders renamed this task from Link inspector shows underscored title as first option to Link inspector shows duplicate underscored title as first option.Jun 26 2019, 3:18 PM

Esanders updated the task description. (Show Details)

Change 519242 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix link normalization when opening inspector

https://gerrit.wikimedia.org/r/519242

gerritbot added a project: Patch-For-Review.Jun 26 2019, 3:19 PM

Could this be the reason behind T225847?

Yep, looks like the same issue.

Esanders added a subtask: T225847: [minor] Multi-word links display underscores in the link inspector.Jun 26 2019, 4:28 PM

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jun 26 2019, 6:55 PM

Change 519242 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix link normalization when opening inspector

https://gerrit.wikimedia.org/r/519242

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jun 26 2019, 7:55 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jun 26 2019, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2019, 8:10 PM

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jul 1 2019, 4:03 PM