Page MenuHomePhabricator
Create Task
Maniphest T226780

Adding icons to dialog actions results in wrong padding
Closed, ResolvedPublic
Actions

Description

Here the icon is blue on blue so not visible:

image.png (192×522 px, 8 KB)

Manually fixing the colour we can see the icon also lacks padding:

image.png (60×93 px, 1 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.33.3mediawiki/coremaster+149 -73
WikimediaUI theme: Fix icon+label padding in process dialog on mobile toooojs/uimaster+10 -2
Update OOUI to v0.33.2mediawiki/coremaster+250 -104
Fix icon+label padding in process dialogoojs/uimaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Jun 27 2019, 10:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 10:15 PM
• Petar.petkovic subscribed.Jun 27 2019, 10:33 PM

I think this was caused by 4524106d9602b08d7ead1d3d91d2120c4c8398db, which also made CX help card look like this:

cx-helpcard.png (164×343 px, 5 KB)

Esanders added a comment.Jun 28 2019, 11:12 AM

@Petar.petkovic that can be fixed by removing the 'primary' flag which was not needed for those buttons, and was previously being ignored.

Esanders updated the task description. (Show Details)Jun 28 2019, 11:13 AM
Esanders added a parent task: T226045: Improve process dialog appearance – simplify actions.Jun 28 2019, 11:23 AM
Esanders mentioned this in T226045: Improve process dialog appearance – simplify actions.Jun 28 2019, 11:37 AM
Esanders added a comment.Jul 3 2019, 8:52 PM

The colour is now fixed, but the padding is still incorrect

Esanders renamed this task from Adding icons to dialog actions results in wrong colour to Adding icons to dialog actions results in wrong padding.Jul 3 2019, 8:58 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Jul 3 2019, 9:24 PM

Change 520638 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Fix icon+label padding in process dialog

https://gerrit.wikimedia.org/r/520638

gerritbot added a project: Patch-For-Review.Jul 3 2019, 9:24 PM
gerritbot added a comment.Jul 3 2019, 9:44 PM

Change 520638 merged by jenkins-bot:
[oojs/ui@master] Fix icon+label padding in process dialog

https://gerrit.wikimedia.org/r/520638

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2019, 10:10 PM
Volker_E closed this task as Resolved.Jul 9 2019, 9:59 PM
Volker_E assigned this task to Esanders.
Volker_E triaged this task as High priority.
Volker_E moved this task from Backlog to OOUI-0.33.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.33.2); removed OOUI.
gerritbot added a comment.Jul 10 2019, 2:13 PM

Change 521875 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875

gerritbot added a project: Patch-For-Review.Jul 10 2019, 2:13 PM
gerritbot added a comment.Jul 10 2019, 3:28 PM

Change 521875 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2019, 4:11 PM
Jdforrester-WMF added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 10 2019, 5:20 PM
gerritbot added a comment.Jul 11 2019, 10:19 PM

Change 522195 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] WikimediaUI theme: Fix icon+label padding in process dialog on mobile too

https://gerrit.wikimedia.org/r/522195

gerritbot added a project: Patch-For-Review.Jul 11 2019, 10:19 PM
matmarex reopened this task as Open.Jul 11 2019, 10:20 PM
matmarex subscribed.

Not fixed on mobile, it's getting override by some other styles.

gerritbot added a comment.Jul 12 2019, 11:12 AM

Change 522195 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Fix icon+label padding in process dialog on mobile too

https://gerrit.wikimedia.org/r/522195

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 12:10 PM
Volker_E edited projects, added OOUI; removed OOUI (OOUI-0.33.2).Jul 12 2019, 1:50 PM
matmarex edited projects, added OOUI (OOUI-0.33.3); removed OOUI.Jul 15 2019, 10:50 PM
Volker_E closed this task as Resolved.Jul 16 2019, 11:57 AM
gerritbot added a comment.Jul 16 2019, 10:02 PM

Change 523823 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.33.3

https://gerrit.wikimedia.org/r/523823

gerritbot added a project: Patch-For-Review.Jul 16 2019, 10:02 PM
gerritbot added a comment.Jul 17 2019, 12:00 AM

Change 523823 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.3

https://gerrit.wikimedia.org/r/523823

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2019, 12:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits