Page MenuHomePhabricator

Adding icons to dialog actions results in wrong padding
Closed, ResolvedPublic

Description

Here the icon is blue on blue so not visible:

image.png (192×522 px, 8 KB)

Manually fixing the colour we can see the icon also lacks padding:

image.png (60×93 px, 1 KB)

Event Timeline

I think this was caused by 4524106d9602b08d7ead1d3d91d2120c4c8398db, which also made CX help card look like this:

cx-helpcard.png (164×343 px, 5 KB)

@Petar.petkovic that can be fixed by removing the 'primary' flag which was not needed for those buttons, and was previously being ignored.

The colour is now fixed, but the padding is still incorrect

Esanders renamed this task from Adding icons to dialog actions results in wrong colour to Adding icons to dialog actions results in wrong padding.Jul 3 2019, 8:58 PM
Esanders updated the task description. (Show Details)

Change 520638 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Fix icon+label padding in process dialog

https://gerrit.wikimedia.org/r/520638

Change 520638 merged by jenkins-bot:
[oojs/ui@master] Fix icon+label padding in process dialog

https://gerrit.wikimedia.org/r/520638

Volker_E assigned this task to Esanders.
Volker_E triaged this task as High priority.
Volker_E moved this task from Backlog to OOUI-0.33.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.33.2); removed OOUI.

Change 521875 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875

Change 521875 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.2

https://gerrit.wikimedia.org/r/521875

Change 522195 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] WikimediaUI theme: Fix icon+label padding in process dialog on mobile too

https://gerrit.wikimedia.org/r/522195

matmarex added a subscriber: matmarex.

Not fixed on mobile, it's getting override by some other styles.

Change 522195 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Fix icon+label padding in process dialog on mobile too

https://gerrit.wikimedia.org/r/522195

Change 523823 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.33.3

https://gerrit.wikimedia.org/r/523823

Change 523823 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.3

https://gerrit.wikimedia.org/r/523823