Statement indicators for problematic constraints are not visible
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	matej_suchanek
	Jul 12 2019, 10:55 AM

Description

Steps to Reproduce

Go to a property (can use sandbox on production Property:P369).
Add a "Mandatory Qualifier Constraint" on that property
Add two property constraints as references on the mandatory qualifier constraint, and give them any two values.

Expected Behavior
Warning indicator should be displayed next to the added Mandatory Qualifier Constraint with the current message being (en):
The parameter "property" must only have a single value.

Current Behavior
No violations indicator is displayed next to the Mandatory Qualifier Constraint

Spotted on
An affected property in Wikidata: Property:P39.
The wbcheckconstraintparameters response contains the violation as expected. This might be a hint that the issue is only in front-end.

Details

	Subject	Repo	Branch	Lines +/-
	Add classes to distinguish between param checks and constraint checks	mediawiki/extensions/WikibaseQualityConstraints	master	+8 -5
	Fix order of actions before loading of the definition icon	mediawiki/extensions/WikibaseQualityConstraints	master	+12 -8

Customize query in gerrit

Related Objects

Mentioned In: rEBQCbd149a368abb: Add classes to distinguish between param checks and constraint checks
rEBQC7f5bebe4419e: Fix order of actions before loading of the definition icon
Mentioned Here: P369 mwgrep for wgCapitalizeUploads

Event Timeline

matej_suchanek created this task.Jul 12 2019, 10:55 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 12 2019, 10:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I tested it in Chromium and I have the same problem. An indicator pops up and then vanishes. It's yellow, which is weird as well.

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Jul 15 2019, 12:07 PM

{"P39$D9B5B54E-3763-42E7-95B2-EB38B15A235A":{"status":"not-okay","problems":[{"message-html":"The parameter &quot;<span class=\"wbqc-role wbqc-role-constraint-parameter-property\"><a title=\"Property:P2306\" href=\"/wiki/Property:P2306\">property</a></span>&quot; must only have a single value."}]}}

@Lucas_Werkmeister_WMDE we will need your help for a quick look at what might be wrong with the mentioned constraint.. specifically to understand whether the icon should really be visible after all, or whether it is just appearing shortly due to some other reason (other than a violation).

The icon should certainly be visible, this constraint should be two constraints to be correct. You can only make one qualifier mandatory at a time (it’s not a “mandatory qualifiers” constraint).

Thanks @Lucas_Werkmeister_WMDE for the clarification now we know what to do

• alaa_wmde triaged this task as High priority.Jul 22 2019, 2:13 PM

• alaa_wmde set the point value for this task to 5.Jul 23 2019, 12:13 PM

• alaa_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.

Rosalie_WMDE moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Aug 5 2019, 2:10 PM

Rosalie_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Rosalie_WMDE subscribed.

Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 5 2019, 10:53 PM

Rosalie_WMDE claimed this task.Aug 6 2019, 8:52 AM

Rosalie_WMDE moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 7 2019, 5:22 AM

In T227866#5336780, @hoo wrote:

{"P39$D9B5B54E-3763-42E7-95B2-EB38B15A235A":{"status":"not-okay","problems":[{"message-html":"The parameter &quot;<span class=\"wbqc-role wbqc-role-constraint-parameter-property\"><a title=\"Property:P2306\" href=\"/wiki/Property:P2306\">property</a></span>&quot; must only have a single value."}]}}

Please what does it represent?

noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 15 2019, 10:22 AM

@hoo

In T227866#5414099, @Rosalie_WMDE wrote:

In T227866#5336780, @hoo wrote:

{"P39$D9B5B54E-3763-42E7-95B2-EB38B15A235A":{"status":"not-okay","problems":[{"message-html":"The parameter &quot;<span class=\"wbqc-role wbqc-role-constraint-parameter-property\"><a title=\"Property:P2306\" href=\"/wiki/Property:P2306\">property</a></span>&quot; must only have a single value."}]}}

Please what does it represent?

Fragment of the API response.

Rosalie_WMDE moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 20 2019, 8:21 AM

• alaa_wmde updated the task description. (Show Details)Aug 21 2019, 10:37 AM

• alaa_wmde updated the task description. (Show Details)

matej_suchanek updated the task description. (Show Details)Aug 21 2019, 11:39 AM

matej_suchanek updated the task description. (Show Details)

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Aug 21 2019, 11:45 AM

noarave claimed this task.Aug 23 2019, 11:50 AM

Restricted Application added a project: User-Noarave. · View Herald TranscriptAug 23 2019, 11:50 AM

noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 23 2019, 11:51 AM

Change 532388 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix missing definition icon for mandatory qualifier constraint

https://gerrit.wikimedia.org/r/532388

gerritbot added a project: Patch-For-Review.Aug 26 2019, 2:57 PM

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2019, 6:19 AM

noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 28 2019, 7:23 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 29 2019, 10:39 AM

Change 533505 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add classes to distinguish between param checks and constraint checks

https://gerrit.wikimedia.org/r/533505

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 2 2019, 9:29 AM

Change 532388 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix order of actions before loading of the definition icon

https://gerrit.wikimedia.org/r/532388

Change 533505 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add classes to distinguish between param checks and constraint checks

https://gerrit.wikimedia.org/r/533505

Jakob_WMDE mentioned this in rEBQC7f5bebe4419e: Fix order of actions before loading of the definition icon.Sep 2 2019, 3:47 PM

Jakob_WMDE mentioned this in rEBQCbd149a368abb: Add classes to distinguish between param checks and constraint checks.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 2 2019, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2019, 4:10 PM

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 3 2019, 6:54 AM