Page MenuHomePhabricator
Create Task
Maniphest T228070

Ref list blanks after first transaction when section editing on mobile
Closed, ResolvedPublic
Actions

Description

This is because the hacks we put in ve.ce.BranchNode to not rendered anything except the section still apply when build CE nodes for the preview.

  1. Open a section with a reference list in it on mobile
  2. Type something
  3. Observe the reference list is now blank

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (e16b98e25)mediawiki/extensions/VisualEditormaster+1 -1
Render internal item nodes when requested individuallyVisualEditor/VisualEditormaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 15 2019, 3:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2019, 3:35 PM
gerritbot added a comment.Jul 15 2019, 3:49 PM

Change 523207 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Render internal item nodes when requested individually

https://gerrit.wikimedia.org/r/523207

gerritbot added a project: Patch-For-Review.Jul 15 2019, 3:49 PM
Esanders added a subscriber: dchan.Jul 15 2019, 3:49 PM
gerritbot added a comment.Jul 15 2019, 9:10 PM

Change 523207 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Render internal item nodes when requested individually

https://gerrit.wikimedia.org/r/523207

Esanders moved this task from Incoming to QA on the VisualEditor (Current work) board.Jul 15 2019, 9:11 PM
gerritbot added a comment.Jul 15 2019, 9:11 PM

Change 523311 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e16b98e25)

https://gerrit.wikimedia.org/r/523311

Esanders updated the task description. (Show Details)Jul 15 2019, 9:13 PM
gerritbot added a comment.Jul 15 2019, 9:26 PM

Change 523311 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e16b98e25)

https://gerrit.wikimedia.org/r/523311

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 10:10 PM
matmarex added a project: Editing QA.Jul 15 2019, 11:27 PM
matmarex moved this task from Inbox to High Priority on the Editing QA board.Jul 15 2019, 11:32 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Jul 26 2019, 3:04 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Sep 3 2019, 12:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits