Page MenuHomePhabricator

Add #pagetriage tag to potential copyright violation log entries
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

The PageTriage extension does not add the 'pagetriage' tag to the log when marking a revision as a potential copyright violation.

Compare the Potential copyright violation log with the Page curation log. You will see the entries in the latter have "Tag: pagetriage". Entries in the former do not.

The rest of the work to add 'pagetriage' tags to PageTriage edits was done as part of T226789.

Steps to reproduce problem
  1. Find a page in Special:NewPagesFeed
  2. Go the the page's history and find a revision
  3. Mark the revision as potential copyvio

You can use the attached script. You will need a user who has the 'pagetriage-copyvio' right.

Expected behavior: In Special:Log?type=pagetriage-copyvio the revision you just marked has an entry with the tag 'pagetriage'.
Observed behavior: It does not.

Attachment

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 22 2019, 2:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 23 2019, 3:23 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.EditedJul 23 2019, 3:23 AM

Once T228352 is actioned I'll test this out on the beta cluster and upload a patch. Also potentialy related: T218110

JTannerWMF moved this task from Inbox to External on the Growth-Team board.Jul 23 2019, 8:23 PM
JTannerWMF added subscribers: ifried, JTannerWMF.

@ifried tagging Community-Tech on this since you all are working on Page Triage

DannyS712 moved this task from Next to Page Curation on the User-DannyS712 board.Aug 27 2019, 11:54 PM

Change 532833 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Publish TagCopyvio log entries with pagetriage tag

https://gerrit.wikimedia.org/r/532833

Change 532833 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Publish TagCopyvio log entries with pagetriage tag

https://gerrit.wikimedia.org/r/532833

dom_walden added a subscriber: kostajh.

The changes above bring copyright violation logging in alignment with how we log other PageTriage actions.

One side effect of this is that copyright violation events are logged in Special:RecentChanges. For example, see entry for 28th August here.

In the past, it appears that the code was deliberately changed to prevent this (T204455#4616674). But, I can see no explanation as to why this was done. Perhaps @kostajh (who made the change) can comment.

For what it is worth, I don't see any problems with logging to Special:RecentChanges. Other PageTriage actions are logged there (e.g. when an article is reviewed). The Potential copyright violation log is already publicly viewable.

In the past, it appears that the code was deliberately changed to prevent this (T204455#4616674). But, I can see no explanation as to why this was done. Perhaps @kostajh (who made the change) can comment.

I wish I could remember, and unfortunately I didn't capture that in the commit or in phab. No doubt the reasoning is somewhere in my team's internal chat logs or standup notes.

For what it is worth, I don't see any problems with logging to Special:RecentChanges. Other PageTriage actions are logged there (e.g. when an article is reviewed). The Potential copyright violation log is already publicly viewable.

Yeah based on that, publishing seems correct.