Page MenuHomePhabricator

Clean up modules in PageTriage
Closed, ResolvedPublic

Description

Work done by @Catrope in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/522581

This ticket is for us to follow up on rebasing and mostly QA, making sure everything still works after this is merged.

Event Timeline

Mooeypoo created this task.Jul 24 2019, 5:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2019, 5:22 PM

Change 522581 had a related patch set uploaded (by Mooeypoo; owner: Catrope):
[mediawiki/extensions/PageTriage@master] Convert ext.pageTriage.views.toolbar to packageFiles

https://gerrit.wikimedia.org/r/522581

Mooeypoo updated the task description. (Show Details)Jul 24 2019, 5:23 PM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.
Krinkle awarded a token.
Krinkle added a subscriber: Krinkle.

Thanks :)

Change 522581 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Convert ext.pageTriage.views.toolbar to packageFiles

https://gerrit.wikimedia.org/r/522581

MusikAnimal added a subscriber: MusikAnimal.

Merged! Correct me if I'm wrong, but this is mostly about performance improvements, in particular ResourceLoader and restructuring of clientside scripting. Everything seemed in working order for me. Moving to QA to get another set of eyes.

dom_walden added a subscriber: dom_walden.

Did a variety of actions:

  • Review and unreview
  • Send message to creator
  • Add a tag
  • Mark for deletion (speedy and proposed)

Compared the API POST requests that were made to my local version before this fix. They matched.

Also WikiLove and AFD (which couldn't do locally) work as I understand them to work.

Briefly interacted with other UI elements, e.g. Next, Close, Minimize.

I had the JavaScript console open in my browser (Firefox 60) all the time. I did not see any errors.

ifried closed this task as Resolved.Jul 31 2019, 5:48 PM
ifried claimed this task.