Page MenuHomePhabricator

Mobile-html sometimes doesn't have etag
Closed, ResolvedPublic

Description

Mobile-html endpoint response sometimes doesn't contain etag. Example:

curl -i http://mobileapps.discovery.wmnet:8888/zh.wikipedia.org/v1/page/mobile-html/%E9%9F%93%E6%98%87%E5%BB%B6 | grep etag

Event Timeline

Pchelolo created this task.Wed, Jul 24, 9:01 PM
Restricted Application added subscribers: Cosine02, Aklapper. · View Herald TranscriptWed, Jul 24, 9:01 PM
bearND added a subscriber: bearND.Wed, Jul 24, 9:07 PM

That's a new thing that I just deployed (T223400). It affects zhwiki. It's out workaround for missing language variant support since Parsoid doesn't handle Chinese lang variants. So instead of requesting it from Parsoid we use action=mobileview instead.

We still need to have an etag in the response, restbase depends on it.

Even if you don't store it?

Also, I thought that zh support for lang variants was deployed, wasn't it? We need to ask @cscott

It only seems to work for srwiki.

I guess we could use the page revision and add a uuid to it to build the etag.

I guess we could use the page revision and add a uuid to it to build the etag.

Ye, that would be good to have. The contract for the service is that it provides an etag no matter what the domain is.

bearND claimed this task.Wed, Jul 24, 9:13 PM
bearND triaged this task as High priority.
bearND moved this task from Needs triage to Kanban on the Reading-Infrastructure-Team-Backlog board.
bearND moved this task from To Do to Doing on the Reading-Infrastructure-Team-Backlog (Kanban) board.

Change 525428 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] mobile-html lang variants: add etag

https://gerrit.wikimedia.org/r/525428

Should PCS also set some more headers, like
Vary: Accept-Encoding, Accept-Language and Content-Language or is this handled by RB?

Change 525428 merged by MSantos:
[mediawiki/services/mobileapps@master] mobile-html lang variants: add etag

https://gerrit.wikimedia.org/r/525428

Mentioned in SAL (#wikimedia-operations) [2019-07-25T17:53:39Z] <mbsantos@deploy1001> Started deploy [mobileapps/deploy@11d9d4a]: Update service-mobileapp-node to 200a323 (T228938 T228287)

Mentioned in SAL (#wikimedia-operations) [2019-07-25T17:58:19Z] <mbsantos@deploy1001> Finished deploy [mobileapps/deploy@11d9d4a]: Update service-mobileapp-node to 200a323 (T228938 T228287) (duration: 04m 39s)

bearND closed this task as Resolved.Fri, Jul 26, 4:51 AM
Shizhao moved this task from Backlog to Closed on the Chinese-Sites board.Mon, Jul 29, 3:17 AM