| santhosh | |
| Aug 6 2019, 9:12 AM |
| F29975286: image.png | |
| Aug 6 2019, 9:12 AM |
The fix for T220495: Content copied from Content Translation into Visual Editor exposes internal attributes caused a regression. Since clipboard mode html convertion of modesl will not have sentnce segments, and since that HTML is used for MT, we no longer has sentence annotations in translated html. So there is no pair in source and target columns, there is no highlighting
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Revert "Don't generate HTML for segments when copying" | mediawiki/extensions/ContentTranslation | master | +6 -13 |
Change 528406 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Revert "Don't generate HTML for segments when copying"
Change 528406 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Revert "Don't generate HTML for segments when copying"
Change 528471 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Re-apply "Don't generate HTML for segments when copying"
Revert for faulty code ended up in production, while another patch listed in comments of this ticket didn't make it into production. However, that other patch actually fixes T220495, not broken sentence highlight, and was wrongly linked to this ticket.
Therefore, you should see sentence highlight in production.
Is that new translation started after 1.34.0-wmf.17 is deployed? Have you seen the problem during first session or after loading the draft? Did you try with unmodified MT or you edited the text? Could you try with another example, started from scratch?
I did try twice in production, with different articles from English to Serbian, with initial session and after loading draft, and sentence highlight is there.
Using production wikis:
Using different language pair with the same Tensor product (en to ca )
Using any different article with math formulas:
Conclusion: it doesn't matter the MT engine nor the language, any article that has math formulas doesn't have highlighting available
Okay, I have tried en:Equation of time to Serbian, in production, since that article has math formulas and I was able to reproduce the problem.