SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: XUn58ApAAEgAAB9eGKcAAACN
Request URL: https://www.wikidata.org/w/api.php?action=wbsgetsuggestions&amp%3Bsearch=&amp%3Bcontext=item&amp%3Bformat=json&amp%3Blanguage=en&amp%3Bcontinue=0&amp%3Bentity=Q14218385

message

[XUn58ApAAEgAAB9eGKcAAACN] /w/api.php?action=wbsgetsuggestions&amp%3Bsearch=&amp%3Bcontext=item&amp%3Bformat=json&amp%3Blanguage=en&amp%3Bcontinue=0&amp%3Bentity=Q14218385   InvalidArgumentException from line 49 of /srv/mediawiki/php-1.34.0-wmf.16/extensions/PropertySuggester/src/SuggesterParamsParser.php: provide either entity-id parameter 'entity' or a list of properties 'properties'

trace

#0 /srv/mediawiki/php-1.34.0-wmf.16/extensions/PropertySuggester/src/GetSuggestions.php(102): PropertySuggester\SuggesterParamsParser->parseAndValidate(array)
#1 /srv/mediawiki/php-1.34.0-wmf.16/includes/api/ApiMain.php(1587): PropertySuggester\GetSuggestions->execute()
#2 /srv/mediawiki/php-1.34.0-wmf.16/includes/api/ApiMain.php(531): ApiMain->executeAction()
#3 /srv/mediawiki/php-1.34.0-wmf.16/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/php-1.34.0-wmf.16/api.php(86): ApiMain->execute()
#5 /srv/mediawiki/w/api.php(3): include(string)
#6 {main}

Notes

Shows up in logs a dozen times today. Nothing for the previous month.

Details

	Subject	Repo	Branch	Lines +/-
	Catch bad params and throw error properly	mediawiki/extensions/PropertySuggester	master	+7 -3

Customize query in gerrit

Related Objects

Mentioned In: rEPS893d7608c5b4: Catch bad params and throw error properly

Event Timeline

brennen created this task.Aug 6 2019, 10:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2019, 10:17 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:05 PM

Krinkle edited projects, added Wikidata-Campsite; removed MediaWiki-REST-API.Oct 17 2019, 6:19 PM

Still reproducible. Adds noise to fatal error log.

Change 560209 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/PropertySuggester@master] Catch bad params and throw error properly

https://gerrit.wikimedia.org/r/560209

gerritbot added a project: Patch-For-Review.Dec 22 2019, 12:52 PM

Ladsgroup claimed this task.Dec 22 2019, 12:52 PM

Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 22 2019, 12:52 PM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 22 2019, 12:52 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 23 2019, 1:15 PM

Change 560209 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Catch bad params and throw error properly

https://gerrit.wikimedia.org/r/560209

Ladsgroup mentioned this in rEPS893d7608c5b4: Catch bad params and throw error properly.Dec 23 2019, 1:58 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 23 2019, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2019, 2:10 PM

brennen added a project: User-brennen.Jan 7 2020, 6:04 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 7 2020, 6:15 PM

Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.

Looks like it is fixed now, per https://logstash.wikimedia.org/goto/8d22f4ae5ce789a8bba7d72a876c097e

Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Jan 27 2020, 3:15 PM

SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'Closed, ResolvedPublicPRODUCTION ERRORActions