Page MenuHomePhabricator

WikiEditor insert file dialog broken
Closed, ResolvedPublic

Description

<juancarlos> [14:57:19] juancarlos: Hello! It seems there's a bug on wiktionary.
<juancarlos> [14:57:37] juancarlos: Using the source code editor, try to use the editing toolbar to insert a file.
<juancarlos> [14:58:16] juancarlos: A dialog box opens but no matter the content you type in, it does not insert it into the editing window.
<juancarlos> [15:08:20] juancarlos: (This does not happen on the English Wikipedia)

Seems to have broken in 1.34.0-wmf.17, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikiEditor/+/524635/ is looking like it missed a spot. Will upload a patch soon.

Event Timeline

Krenair created this task.Wed, Aug 7, 10:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Aug 7, 10:54 PM

Change 528964 had a related patch set uploaded (by Alex Monk; owner: Alex Monk):
[mediawiki/extensions/WikiEditor@master] Follow-up Ia75d685c: Fix the insert file dialog

https://gerrit.wikimedia.org/r/528964

Change 529075 had a related patch set uploaded (by Krinkle; owner: Alex Monk):
[mediawiki/extensions/WikiEditor@wmf/1.34.0-wmf.17] Follow-up Ia75d685c: Fix the insert file dialog

https://gerrit.wikimedia.org/r/529075

Change 528964 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Follow-up Ia75d685c: Fix the insert file dialog

https://gerrit.wikimedia.org/r/528964

Change 529075 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@wmf/1.34.0-wmf.17] Follow-up Ia75d685c: Fix the insert file dialog

https://gerrit.wikimedia.org/r/529075

Mentioned in SAL (#wikimedia-operations) [2019-08-08T23:49:19Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.17/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.config.js: SWAT: 6dcab39: Follow-up Ia75d685c: Fix the insert file dialog (T230078) (duration: 00m 50s)

Krenair closed this task as Resolved.Thu, Aug 8, 11:52 PM