Page MenuHomePhabricator

Add user module incl user name to store
Closed, DeclinedPublic

Description

  • add store module
  • copy user name from window

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2019, 11:20 AM

Change 533180 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Makeing ForeinRepo responsible

https://gerrit.wikimedia.org/r/533180

Actually we do not need a user store module and for the user name can be part of the save repo until we have a state changing behavior for users. That is the reason why the actual patch does not include a store change at all. I would love some different thoughts on that!

I totally agree with the approach of making the user name a repository constructor argument instead of putting it in the store somewhere.

I’m tempted to say that we should close this task as Declined and reattach the Gerrit change to T230335: Create SavingEntityRepository – after all, it now implements something completely different from what this task describes.

Change 533180 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Makeing ForeignRepo responsible for holding username

https://gerrit.wikimedia.org/r/533180