Description

add store module
copy user name from window

Details

	Subject	Repo	Branch	Lines +/-
	bridge: Makeing ForeignRepo responsible for holding username	mediawiki/extensions/Wikibase	master	+79 -56

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T224833 first client edit for simple typo
Resolved	Lydia_Pintscher	T226999 Save Wikidata edit when submitting client edit modal
Resolved	• Matthias_Geisler_WMDE	T230335 Create SavingEntityRepository
Declined	• Matthias_Geisler_WMDE	T230331 Add user module incl user name to store

Event Timeline

• Pablo-WMDE created this task.Aug 12 2019, 11:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2019, 11:20 AM

Michael edited projects, added Wikidata-Bridge-Sprint-3; removed Wikidata-Bridge.Aug 21 2019, 8:09 AM

• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-4.Aug 28 2019, 8:35 AM

• Matthias_Geisler_WMDE claimed this task.Aug 29 2019, 8:27 AM

• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-4 board.

Change 533180 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Makeing ForeinRepo responsible

https://gerrit.wikimedia.org/r/533180

gerritbot added a project: Patch-For-Review.Aug 29 2019, 10:16 AM

Actually we do not need a user store module and for the user name can be part of the save repo until we have a state changing behavior for users. That is the reason why the actual patch does not include a store change at all. I would love some different thoughts on that!

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-4 board.Aug 29 2019, 10:37 AM

I totally agree with the approach of making the user name a repository constructor argument instead of putting it in the store somewhere.

I’m tempted to say that we should close this task as Declined and reattach the Gerrit change to T230335: Create SavingEntityRepository – after all, it now implements something completely different from what this task describes.