- pass in closing callback from into to app, e.g. https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/client/data-bridge/src/mediawiki/init.ts#46
- see if potentially repeated calls to prepareContainer cause problems (e.g. many HTML elements added, ...). See https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/client/data-bridge/src/mediawiki/prepareContainer.ts#39
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Lydia_Pintscher | T224833 first client edit for simple typo | |||
Resolved | Lydia_Pintscher | T226999 Save Wikidata edit when submitting client edit modal | |||
Resolved | • Matthias_Geisler_WMDE | T230337 Close Application on successful save |
Event Timeline
Change 535202 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Introduce OODialogCloseHandler
Change 535349 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: wire up CloseHandler with store
Change 535769 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: External Events
Change 535349 abandoned by Matthias Geisler:
bridge: wire up CloseHandler with store
Reason:
In favor of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /535769/
Change 535202 abandoned by Matthias Geisler:
bridge: Introduce OOWindowCloseHandler
Reason:
in favor of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /535769/
Change 535769 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: External Events