Migrate Scribunto to stop using MediaWikiIntegrationTestCase on unit tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Aug 19 2019, 2:06 AM

Description

Scribunto has lots of tests that are slow and most of them don't need MediaWikiIntegrationTestCase that has a large overhead but still they use it making it rather slow.

Details

	Subject	Repo	Branch	Lines +/-
	Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase	mediawiki/extensions/Scribunto	master	+290 -150

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T229180 Migrate extensions to stop using MediaWikiIntegrationTestCase on unit tests
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Resolved	Ladsgroup	T230701 Migrate Scribunto to stop using MediaWikiIntegrationTestCase on unit tests

Event Timeline

Ladsgroup created this task.Aug 19 2019, 2:06 AM

• mobrovac moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Aug 19 2019, 9:58 AM

• kchapman triaged this task as Low priority.Aug 20 2019, 6:16 PM

• kchapman edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

Change 527854 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Scribunto@master] Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase

https://gerrit.wikimedia.org/r/527854

gerritbot added a project: Patch-For-Review.Aug 24 2019, 12:01 PM

Krinkle added a parent task: T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.Aug 26 2019, 12:04 PM

Krinkle mentioned this in T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.

WDoranWMF moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Aug 27 2019, 12:46 PM

Change 527854 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase

https://gerrit.wikimedia.org/r/527854

Ladsgroup mentioned this in rELUA248dcae392ef: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase.Aug 31 2019, 1:53 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 31 2019, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2019, 2:10 PM

Ladsgroup closed this task as Resolved.Sep 2 2019, 11:11 AM

Ladsgroup claimed this task.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 2 2019, 11:11 AM

Ladsgroup mentioned this in T125050: [Task] Add Scribunto to extension-gate in CI.Sep 2 2019, 11:13 AM