| Esanders | |
| Aug 20 2019, 2:49 PM |
| F30050176: image.png | |
| Aug 20 2019, 2:49 PM |
Previously the edit toolbar wasn't shown until first focus, so the disabled tools were never visible.
Since we introduced document mode for selections, it is no longer possible to change the selection back to null, so the tools never become disabled again during the edit.
The solution would be to initialise the selection to the first content offset, but deactivated so the keyboard doesn't show.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MobileArticleTarget: v1 of toolbar refresh | mediawiki/extensions/VisualEditor | master | +54 -152 |
That screenshot does also remind me that we should, perhaps, hide the toolbar while that modal is displayed? Having non-disabled tools while the modal is present would be weird as well, after all.
Change 527452 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: v1 of toolbar refresh
Yes, that came up as well and was filed as T230806: Showing the v1 toolbar with anon edit warning could be confusing.
Change 527452 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: v1 of toolbar refresh