Disabling the recent changes highlighting feature on Minerva
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 22 2019, 11:01 PM

Description

Highlighting can be enabled if following a URL e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&limit=50&days=7&enhanced=1&damaging__likelygood_color=c2&urlversion=2

If you have highlighted results as part of a saved filter and you select that filter then highlighting appears on mobile and things get kinda messy.

Acceptance criteria

Highlighting is disabled on Minerva skin.

Developer notes

We will disable the feature.

We can hide the dots to the left and the filters themselves using:

.mw-rcfilters-ui-itemMenuOptionWidget-highlightButton,
 .mw-rcfilters-ui-highlights { display: none !important; }

The highlight backgrounds would remain.

A cleaner version would be to see if we can disable the feature altogether like we did with group changes

QA Results

AC	Status	Details
1	✅	T231054#5481687
2	✅	T231054#5481687

Details

	Subject	Repo	Branch	Lines +/-
	Removing highlighting from mobile rcfilters	mediawiki/core	master	+27 -21

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Goal	ovasileva	T198313 [GOAL] Advanced mobile contributions
Resolved		ovasileva	T228916 Deploy AMC to all Wikipedias
Resolved		ovasileva	T223922 [EPIC] Display core version of recent changes page for AMC users
Open		None	T229360 [Tracking/Epic] Problems with RecentChanges and Watchlist advanced mobile contribution experience
Resolved	BUG REPORT	ovasileva	T231054 Disabling the recent changes highlighting feature on Minerva

Event Timeline

Jdlrobson created this task.Aug 22 2019, 11:01 PM

Jdlrobson updated the task description. (Show Details)

2 possible solutions needing input from Alex.

I think disabling makes the most sense as it's most consistent with the default experience (not having any saved filters)

ovasileva triaged this task as Medium priority.Aug 23 2019, 3:56 PM

ovasileva moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson renamed this task from Highlighting on mobile is messy - disable or make work? to [Needs estimate/discussion] Highlighting on mobile is messy - disable or make work?.Aug 23 2019, 4:10 PM

I think disabling highlighting for mobile is reasonable in that:

I assume people won't be too confused if they select a saved filter on mobile that (on desktop) has highlighting rules but don't see the highlights present
it will be difficult to cleanly include the highlighting UI controls in the mobile interface
(not as relevant) the current experience where saved filters can have highlighting, but otherwise highlighting is missing from the interface is confusing

Jdlrobson updated the task description. (Show Details)Aug 26 2019, 6:59 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from [Needs estimate/discussion] Highlighting on mobile is messy - disable or make work? to [Needs estimate/discussion] Disabling the recent changes highlighting feature on mobile.Aug 26 2019, 7:12 PM

Jdlrobson renamed this task from [Needs estimate/discussion] Disabling the recent changes highlighting feature on mobile to [Needs estimate/discussion] Disabling the recent changes highlighting feature on Minerva.

From @Jdrewniak: what happens if we just disable the RC filter ResourceLoader module?

ovasileva set the point value for this task to 5.Aug 27 2019, 4:37 PM

ovasileva renamed this task from [Needs estimate/discussion] Disabling the recent changes highlighting feature on Minerva to Disabling the recent changes highlighting feature on Minerva.Aug 27 2019, 4:57 PM

Jdrewniak claimed this task.Aug 28 2019, 1:22 PM

Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Change 533890 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/core@master] Removing highlighting from mobile rcfilters

https://gerrit.wikimedia.org/r/533890

gerritbot added a project: Patch-For-Review.Sep 2 2019, 11:20 AM

Jdrewniak moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 2 2019, 11:36 AM

Change 533890 merged by jenkins-bot:
[mediawiki/core@master] Removing highlighting from mobile rcfilters

https://gerrit.wikimedia.org/r/533890

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.19; 2019-08-20).Sep 3 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2019, 7:10 PM

Jdlrobson reassigned this task from Jdrewniak to Edtadros.Sep 3 2019, 8:17 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

@Jdlrobson is it sufficient that I cannot see the option to highlight with AMC On or Off, Logged In or Out?

In T231054#5468156, @Edtadros wrote:

@Jdlrobson is it sufficient that I cannot see the option to highlight with AMC On or Off, Logged In or Out?

Provided this is on mobile. We should also check that these features are still available when you switch to desktop mode! :)

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

✅ AC1: Highlighting is disabled on Mobile

✅ AC2: Highlighting is still enabled on Desktop Minerva

Edtadros updated the task description. (Show Details)Sep 11 2019, 1:00 AM

Looks good!

	F30296748: T231054-1.gif
	Sep 11 2019, 12:59 AM

	F30296751: T231054-2.gif
	Sep 11 2019, 12:59 AM

Disabling the recent changes highlighting feature on MinervaClosed, ResolvedPublic5 Estimated Story PointsBUG REPORTActions