Page MenuHomePhabricator
Create Task
Maniphest T231353

BadFileLookup.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget or be null, boolean given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: XWVbRgpAAEQAADM-Pf8AAABN
Request URL: www.mediawiki.org/wiki/Category:Documentation

message
[XWVbRgpAAEQAADM-Pf8AAABN] /wiki/Category:Documentation   TypeError from line 61 of /srv/mediawiki/php-1.34.0-wmf.20/includes/BadFileLookup.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget or be null, boolean given, called in /srv/mediawiki/php-1.34.0-wmf.20/includes/gallery/TraditionalImageGallery.php on line 115
trace
#0 /srv/mediawiki/php-1.34.0-wmf.20/includes/gallery/TraditionalImageGallery.php(115): MediaWiki\BadFileLookup->isBadFile(string, boolean)
#1 /srv/mediawiki/php-1.34.0-wmf.20/includes/CategoryViewer.php(472): TraditionalImageGallery->toHTML()
#2 /srv/mediawiki/php-1.34.0-wmf.20/includes/CategoryViewer.php(120): CategoryViewer->getImageSection()
#3 /srv/mediawiki/php-1.34.0-wmf.20/includes/page/CategoryPage.php(117): CategoryViewer->getHTML()
#4 /srv/mediawiki/php-1.34.0-wmf.20/includes/page/CategoryPage.php(72): CategoryPage->closeShowCategory()
#5 /srv/mediawiki/php-1.34.0-wmf.20/includes/actions/ViewAction.php(63): CategoryPage->view()
#6 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(507): ViewAction->show()
#7 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(302): MediaWiki->performAction(CategoryTreeCategoryPage, Title)
#8 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(892): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(523): MediaWiki->main()
#10 /srv/mediawiki/php-1.34.0-wmf.20/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Impact

7 hits in the last hour, not seen before.

Notes

Since it's a new error, it's blocking the train.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
BadFileLookup::isBadFile() expects null, not falsemediawiki/coremaster+6 -8
BadFileLookup::isBadFile() expects null, not falsemediawiki/corewmf/1.34.0-wmf.20+6 -8
Revert "BadFileLookup to replace wfIsBadImage"mediawiki/coremaster+142 -426
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Aug 27 2019, 4:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 4:42 PM
zeljkofilipin triaged this task as Unbreak Now! priority.Aug 27 2019, 4:43 PM
zeljkofilipin added a parent task: T220745: 1.34.0-wmf.20 deployment blockers.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 27 2019, 4:43 PM
gerritbot added a comment.Aug 27 2019, 4:52 PM

Change 532744 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "BadFileLookup to replace wfIsBadImage"

https://gerrit.wikimedia.org/r/532744

gerritbot added a project: Patch-For-Review.Aug 27 2019, 4:52 PM
gerritbot added a comment.Aug 27 2019, 5:23 PM

Change 532754 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532754

Krinkle moved this task from Untriaged to Aug2019/1.34.wmf.17+ on the Wikimedia-production-error board.Aug 27 2019, 5:52 PM
gerritbot added a comment.Aug 27 2019, 6:25 PM

Change 532754 merged by jenkins-bot:
[mediawiki/core@master] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532754

gerritbot added a comment.Aug 27 2019, 6:31 PM

Change 532762 had a related patch set uploaded (by Jforrester; owner: simetrical):
[mediawiki/core@wmf/1.34.0-wmf.20] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532762

gerritbot added a comment.Aug 27 2019, 6:53 PM

Change 532762 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.20] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532762

Stashbot mentioned this in T231340: TraditionalImageGallery.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget, bool given.Aug 27 2019, 6:58 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-27T18:58:01Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.20/includes/api/ApiQueryImageInfo.php: T231340 T231353 BadFileLookup::isBadFile() expects null, not false for the API (duration: 00m 53s)

Stashbot added a comment.Aug 27 2019, 6:59 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-27T18:59:28Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.20/includes/gallery/ImageGalleryBase.php: T231340 T231353 BadFileLookup::isBadFile() expects null, not false for galleries (duration: 00m 53s)

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 27 2019, 7:00 PM
Jdforrester-WMF closed this task as Resolved.Aug 27 2019, 7:04 PM
Jdforrester-WMF assigned this task to Simetrical.
Jdforrester-WMF added subscribers: Simetrical, Jdforrester-WMF.

OK, this seems now to be fixed. Thanks @Simetrical!

gerritbot added a comment.Aug 27 2019, 8:34 PM

Change 532744 abandoned by Jforrester:
Revert "BadFileLookup to replace wfIsBadImage"

https://gerrit.wikimedia.org/r/532744

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 9:10 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits