TraditionalImageGallery.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget, bool given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	zeljkofilipin
	Aug 27 2019, 3:50 PM

Description

Error

Request ID: XWVOvApAMFUAAL8av3sAAAAG
Request URL: https://www.mediawiki.org/wiki/Category:Help

message

[XWVOvApAMFUAAL8av3sAAAAG] /wiki/Category:Help   PHP Fatal Error from line 115 of /srv/mediawiki/php-1.34.0-wmf.20/includes/gallery/TraditionalImageGallery.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget, bool given

trace

#0 /srv/mediawiki/php-1.34.0-wmf.20/includes/gallery/TraditionalImageGallery.php(115): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.34.0-wmf.20/includes/CategoryViewer.php(472): TraditionalImageGallery->toHTML()
#2 /srv/mediawiki/php-1.34.0-wmf.20/includes/CategoryViewer.php(120): CategoryViewer->getImageSection()
#3 /srv/mediawiki/php-1.34.0-wmf.20/includes/page/CategoryPage.php(117): CategoryViewer->getHTML()
#4 /srv/mediawiki/php-1.34.0-wmf.20/includes/page/CategoryPage.php(72): CategoryPage->closeShowCategory()
#5 /srv/mediawiki/php-1.34.0-wmf.20/includes/actions/ViewAction.php(63): CategoryPage->view()
#6 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(507): ViewAction->show()
#7 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(302): MediaWiki->performAction(CategoryTreeCategoryPage, Title)
#8 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(892): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.34.0-wmf.20/includes/MediaWiki.php(523): MediaWiki->main()
#10 /srv/mediawiki/php-1.34.0-wmf.20/index.php(42): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

Impact

14 hits in the last hour, 20 in the last 4 hours, not seen before that.

Notes

Since it's a new error, it's blocking the train.

Steps to reproduce:

go to https://www.mediawiki.org/wiki/Category:Help
error message is displayed: [XWVRPApAME8AAHMDt7oAAABG] 2019-08-27 15:50:21: Fatal exception of type "TypeError"

Details

Subject	Repo	Branch	Lines +/-
BadFileLookup::isBadFile() expects null, not false	mediawiki/core	master	+6 -8
BadFileLookup::isBadFile() expects null, not false	mediawiki/core	wmf/1.34.0-wmf.20	+6 -8
Revert "BadFileLookup to replace wfIsBadImage"	mediawiki/core	master	+142 -426

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	zeljkofilipin	T220745 1.34.0-wmf.20 deployment blockers
		Resolved	PRODUCTION ERROR	Simetrical	T231340 TraditionalImageGallery.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget, bool given

Event Timeline

zeljkofilipin created this task.Aug 27 2019, 3:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 3:50 PM

zeljkofilipin triaged this task as Unbreak Now! priority.Aug 27 2019, 3:50 PM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 27 2019, 3:50 PM

zeljkofilipin updated the task description. (Show Details)Aug 27 2019, 3:51 PM

zeljkofilipin added a parent task: T220745: 1.34.0-wmf.20 deployment blockers.

Any categories having images end up being broken https://www.mediawiki.org/wiki/Category:Documentation

hashar updated the task description. (Show Details)Aug 27 2019, 4:30 PM

Also CategoryTree output is quite broken: https://en.wikipedia.beta.wmflabs.org/wiki/Category:People_by_ethnicity

TraditionalImageGallery has a change this train, https://gerrit.wikimedia.org/r/c/mediawiki/core/+/530829
CategoryViewer hasn't changed for six months (last was https://gerrit.wikimedia.org/r/c/mediawiki/core/+/494879 )
CategoryPage hasn't changed for two years (last was https://gerrit.wikimedia.org/r/c/mediawiki/core/+/406412 )

The ImageGallery change look benign – that should be a like-for-like function? – but clearly it isn't.

CategoryTree's latest real change is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CategoryTree/+/526601 which shipped in wmf.19.

Change 532744 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "BadFileLookup to replace wfIsBadImage"

https://gerrit.wikimedia.org/r/532744

gerritbot added a project: Patch-For-Review.Aug 27 2019, 4:52 PM

zeljkofilipin updated the task description. (Show Details)Aug 27 2019, 5:00 PM

Change 532754 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532754

Krinkle moved this task from Untriaged to Aug2019/1.34.wmf.17+ on the Wikimedia-production-error board.Aug 27 2019, 5:53 PM

Change 532754 merged by jenkins-bot:
[mediawiki/core@master] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532754

Change 532762 had a related patch set uploaded (by Jforrester; owner: simetrical):
[mediawiki/core@wmf/1.34.0-wmf.20] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532762

Change 532762 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.20] BadFileLookup::isBadFile() expects null, not false

https://gerrit.wikimedia.org/r/532762

Mentioned in SAL (#wikimedia-operations) [2019-08-27T18:58:01Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.20/includes/api/ApiQueryImageInfo.php: T231340 T231353 BadFileLookup::isBadFile() expects null, not false for the API (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2019-08-27T18:59:28Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.20/includes/gallery/ImageGalleryBase.php: T231340 T231353 BadFileLookup::isBadFile() expects null, not false for galleries (duration: 00m 53s)

OK, this seems now to be fixed. Thanks @Simetrical! (Will open a different task about the CategoryTree corruption.)

Change 532744 abandoned by Jforrester:
Revert "BadFileLookup to replace wfIsBadImage"

https://gerrit.wikimedia.org/r/532744

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2019, 9:10 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:05 PM

TraditionalImageGallery.php: Argument 2 passed to MediaWiki\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget, bool givenClosed, ResolvedPublicPRODUCTION ERRORActions