ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	zeljkofilipin
	Aug 29 2019, 11:46 AM

Description

Error

message

[XWe3ZwpAIDUAAKd6o60AAAAR] /w/api.php?action=query&list=cxtranslatorstats&translator=-1'%20OR%203*2<(0%2b5%2b436-436)%20or%20'jrjJT0jF'='   PHP Fatal Error from line 27 of /srv/mediawiki/php-1.34.0-wmf.19/extensions/ContentTranslation/api/ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given

Impact

252 hits for wmf.19, 2 hits for wmf.14. Not seen before that.

Notes

I'm not sure if the error in wmf.14 is the same as in wmf.19, so this is blocking the train.

Details

Request ID: XWe3ZwpAIDUAAKd6o60AAAAR
Request URL: jam.wikipedia.org/w/api.php...

Stack Trace

trace

#0 /srv/mediawiki/php-1.34.0-wmf.19/extensions/ContentTranslation/api/ApiQueryTranslatorStats.php(27): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiQuery.php(250): ApiQueryTranslatorStats->execute()
#2 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiMain.php(1589): ApiQuery->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiMain.php(533): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.34.0-wmf.19/includes/api/ApiMain.php(504): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.34.0-wmf.19/api.php(86): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)
#7 {main}

	Subject	Repo	Branch	Lines +/-
	Fix PHP notice in ApiQueryTranslatorStats	mediawiki/extensions/ContentTranslation	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T231561: ApiQueryMapData.php: Call to a member function getData() on null
T231567: Translator.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, boolean given

Event Timeline

zeljkofilipin created this task.Aug 29 2019, 11:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2019, 11:46 AM

zeljkofilipin updated the task description. (Show Details)Aug 29 2019, 11:47 AM

zeljkofilipin added a parent task: T220745: 1.34.0-wmf.20 deployment blockers.

This just looks like the same injection thing hitting a new API module. We'll fix it, but suggesting that this doesn't need to block the train.

Change 533212 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Fix PHP notice in ApiQueryTranslatorStats

https://gerrit.wikimedia.org/r/533212

gerritbot added a project: Patch-For-Review.Aug 29 2019, 1:51 PM