Page MenuHomePhabricator

Wikimedia login plugin for Discourse shouldn't require "real name" from MediaWiki
Closed, ResolvedPublic

Description

Currently the Wikimedia login for Discourse requires the real name property from MediaWiki.

In order to complete your request, Wikimedia Developer Support needs permission to access information about you, including your real name and email address, on all projects of this site.

However, we usually don't require real names, and on top of this Wikimedia wikis don't even have this field enabled.

Therefore, the plugin shouldn't request users their real name, Wikimedia username and email address is enough.

Note that Discourse has a "Name" field in the user preferences, that is optional. The plugin shouldn't touch this Name field in Discourse. Wikimedia Space users willing to add a name there can do so.

Event Timeline

Qgil created this task.Sep 3 2019, 1:47 PM
Qgil renamed this task from Wikimedia plugin for Discourse shouldn't pull "real name" from MediaWiki to Wikimedia plugin for Discourse shouldn't require "real name" from MediaWiki.Sep 3 2019, 2:20 PM
Qgil renamed this task from Wikimedia plugin for Discourse shouldn't require "real name" from MediaWiki to Wikimedia login plugin for Discourse shouldn't require "real name" from MediaWiki.
Tgr added a comment.Sep 3 2019, 7:15 PM

This seems pointless. There is no separate grant for just email vs. realname+email so you'll receive it whether you request it or not; making use of it by suggesting it as a default display name seems like the reasonable thing for the plugin to do when interfacing with a MediaWiki that has real names enabled.

I think what you really mean here is T151515: authonlyprivate OAuth grant should not mention real name when the wiki does not allow them which is a (fairly easy) MediaWiki-side development task.

@Tgr the developer has added a fix: "Prevent the realname property returned by wikimedia from being used in Discourse" and has also added additional text to the create account modal that allows anyone to input their realname/alternative name if they'd like.

We'd definitely be interested in making it so that this text doesn't include real name for Space.

It appears I should follow that up on T151515: authonlyprivate OAuth grant should not mention real name when the wiki does not allow them? Or is there something else you'd also recommend to attempt to modify that?

Tgr added a comment.Sep 3 2019, 10:09 PM

@Tgr the developer has added a fix: "Prevent the realname property returned by wikimedia from being used in Discourse" and has also added additional text to the create account modal that allows anyone to input their realname/alternative name if they'd like.

That doesn't fix any real problem we have and probably makes the plugin less useful for third parties.

It appears I should follow that up on T151515: authonlyprivate OAuth grant should not mention real name when the wiki does not allow them?

Yeah. That's a MediaWiki issue, there's nothing an OAuth application needing email addresses can do to affect it.

Qgil triaged this task as Normal priority.Sep 4 2019, 9:52 AM
Qgil moved this task from Backlog to Started on the Space (Jul-Sep-2019) board.
elappen-WMF closed this task as Resolved.Mon, Sep 16, 11:49 PM

As stated, the plugin currently doesn't attempt to view real name, and advancement on T151515: authonlyprivate OAuth grant should not mention real name when the wiki does not allow them means that the OAuth grant is close to correctly reflecting this.

I am resolving this task as it is closed from a Space perspective, with only a small amount remaining to be resolved from a MediaWiki perspective.

Qgil awarded a token.Tue, Sep 17, 7:04 AM
Qgil moved this task from Started to Evaluated on the Space (Jul-Sep-2019) board.