Maniphest T231966

Phan job should use composer instead of vendor for release branches ( undeclared class \Wikimedia\Equivset\Equivset )
Open, MediumPublic
Actions

Assigned To

None

Authored By

	hashar
	Sep 4 2019, 7:51 AM

Description

mediawiki/vendor.git release branches do not contain the dependencies for all projects. For release branches the test/gate-and-submit pipeline have been switched to use composer instead of vendor (T189560).

We would need a phan jobs that uses composer since the job currently fail, for example on AbuseFilter REL1_33 ( https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/534293/ ):

<?xml version="1.0" encoding="ISO-8859-15"?>
<checkstyle version="6.5">
  <file name="includes/parser/AbuseFilterParser.php">
    <error line="71" severity="warning" message="Property \AbuseFilterParser::$equivset has undeclared type \Wikimedia\Equivset\Equivset" source="PhanUndeclaredTypeProperty"/>
    <error line="1275" severity="error" message="Call to method __construct from undeclared class \Wikimedia\Equivset\Equivset" source="PhanUndeclaredClassMethod"/>
    <error line="1278" severity="error" message="Call to method normalize from undeclared class \Wikimedia\Equivset\Equivset" source="PhanUndeclaredClassMethod"/>
  </file>
</checkstyle>

Details

	Subject	Repo	Branch	Lines +/-
	Zuul: [mediawiki/extensions/Wikibase] Disable Phan on release branches	integration/config	master	+12 -6
	jjb: convert phan jobs to job templates	integration/config	master	+18 -7

Customize query in gerrit

Related Objects

Mentioned In: T326374: Make Phan on PHP 8.1 voting on REL1_39
T271428: Bump php-ast to 1.0.10 for all phan jobs
T256088: REL1_33 and REL1_34 mediawiki-core-php72-phan-docker broken
T104807: Older hidden versions of a currently-public AbuseFilter are exposed via diffs (CVE-2019-18612)
T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball
T226945: Decide on future of running Phan tests on release branches
Mentioned Here: T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball
T226945: Decide on future of running Phan tests on release branches

Event Timeline

hashar created this task.Sep 4 2019, 7:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2019, 7:51 AM

hashar mentioned this in T226945: Decide on future of running Phan tests on release branches.Sep 4 2019, 7:52 AM

hashar mentioned this in T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball.

hashar added projects: Release-Engineering-Team-TODO, Release-Engineering-Team (CI & Testing services).

Daimona subscribed.Sep 4 2019, 9:07 AM

Change 534395 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] jjb: convert phan jobs to job templates

https://gerrit.wikimedia.org/r/534395

gerritbot added a project: Patch-For-Review.Sep 4 2019, 9:41 AM

For now I have removed the Phan jobs from the release branches ( https://gerrit.wikimedia.org/r/#/c/integration/config/+/534426/ ).

Change 534395 merged by jenkins-bot:
[integration/config@master] jjb: convert phan jobs to job templates

https://gerrit.wikimedia.org/r/534395

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 6:10 PM

Daimona mentioned this in T104807: Older hidden versions of a currently-public AbuseFilter are exposed via diffs (CVE-2019-18612).Oct 29 2019, 4:58 PM

Daimona mentioned this in T256088: REL1_33 and REL1_34 mediawiki-core-php72-phan-docker broken.Jun 23 2020, 10:07 AM

thcipriani edited projects, added Release-Engineering-Team; removed Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO.Jan 12 2021, 5:19 PM

Daimona mentioned this in T271428: Bump php-ast to 1.0.10 for all phan jobs.Jan 14 2021, 9:52 PM

The reason against doing this is that for Wikimedia production we want to precisely match the exact versions we have available (and don't want e.g. a conditional dependency turn into a full but unmet dependency that phan doesn't flag until we deploy). However, I think we'd catch that through other means at this point, and so migrating all these jobs from a vendor check-out to a composer-based on should work without loss of test coverage. Thoughts?

thcipriani assigned this task to hashar.Jun 29 2021, 5:42 PM

thcipriani edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team.

hashar removed hashar as the assignee of this task.Nov 10 2021, 10:13 AM

thcipriani edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team (Doing).Sep 7 2022, 3:51 PM

Reedy mentioned this in T326374: Make Phan on PHP 8.1 voting on REL1_39.Jan 12 2023, 7:36 PM

Change 984222 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] Zuul: [mediawiki/extensions/Wikibase] Disable Phan on release branches

https://gerrit.wikimedia.org/r/984222

gerritbot added a project: Patch-For-Review.Dec 19 2023, 3:46 PM

Change 984222 merged by jenkins-bot: