Despite us using the language fallback chain, and despite the fact that "this should never be the case", there still can be properties (or any entity) which do not have any labels whatsoever. Currently ForeignApiEntityLabelRepository (made during T231465) does not handle this gracefully, but should.
I think (technically) throwing a dedicated exception and (ux-wise) showing the property id as a consequence should be acceptable ways of handling that.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
bridge: handle property without label in language | mediawiki/extensions/Wikibase | master | +27 -0 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Lydia_Pintscher | T224833 first client edit for simple typo | |||
Resolved | Lydia_Pintscher | T227759 Show label for Property in Wikidata Bridge modal | |||
Resolved | BUG REPORT | • Pablo-WMDE | T232497 Handle properties with no label whatsoever |
Event Timeline
Comment Actions
Change 535648 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: handle property without label in language
Comment Actions
Change 535648 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: handle property without label in language