Page MenuHomePhabricator

Handle properties with no label whatsoever
Closed, ResolvedPublicBUG REPORT

Description

Despite us using the language fallback chain, and despite the fact that "this should never be the case", there still can be properties (or any entity) which do not have any labels whatsoever. Currently ForeignApiEntityLabelRepository (made during T231465) does not handle this gracefully, but should.
I think (technically) throwing a dedicated exception and (ux-wise) showing the property id as a consequence should be acceptable ways of handling that.

Event Timeline

Change 535648 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: handle property without label in language

https://gerrit.wikimedia.org/r/535648

Change 535648 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: handle property without label in language

https://gerrit.wikimedia.org/r/535648