Page MenuHomePhabricator

Handle properties with no label whatsoever
Closed, ResolvedPublicBUG REPORT


Despite us using the language fallback chain, and despite the fact that "this should never be the case", there still can be properties (or any entity) which do not have any labels whatsoever. Currently ForeignApiEntityLabelRepository (made during T231465) does not handle this gracefully, but should.
I think (technically) throwing a dedicated exception and (ux-wise) showing the property id as a consequence should be acceptable ways of handling that.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2019, 4:19 PM
Pablo-WMDE updated the task description. (Show Details)
Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-4 board.

Change 535648 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: handle property without label in language

Change 535648 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: handle property without label in language

Pablo-WMDE closed this task as Resolved.Sep 11 2019, 10:21 AM
Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-5 board.