Page MenuHomePhabricator

"empty" InitialiseSettings.php breaks a ton of links and references to that file
Closed, DeclinedPublic

Description

All the settings in InitialiseSettings.php have been moved to VariantSettings.php with
rOMWCfea69395e38699e46a5a82ff1e5884c21cf48e5d , leaving no actual settings in the former file. Apparently this is part of T223602??

Is this a permanent thing? Because it renders useless a shit-ton of existing links and verbal references to, say, https://noc.wikimedia.org/conf/InitialiseSettings.php and https://noc.wikimedia.org/conf/InitialiseSettings.php.txt (e.g., "this is because this wiki has variable X set to value Y in InitialiseSettings.php" or "to get this behavior, you need to request change C be made to InitialiseSettings.php").

Event Timeline

Dcljr created this task.Sep 17 2019, 3:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2019, 3:31 AM

Change was made by @Jdforrester-WMF (pinging).

Dinoguy1000 added a subscriber: Dinoguy1000.EditedSep 17 2019, 5:47 AM

This change breaks AutoWikiBrowser logins; see T233070.

Dinoguy1000 renamed this task from "empty" initialiseSettings.php breaks a ton of links and references to that file to "empty" InitialiseSettings.php breaks a ton of links and references to that file.Sep 17 2019, 5:51 AM

This change breaks AutoWikiBrowser logins; see T233070.

IMO, AWB shouldn't parse raw configuration - that can change at any time, for any reason, and can't be deemed to be stable.

I'm sad that the commit message does not offer [a link to] a rationale behind this change.

They should be accessible through VarientConfig.php. The plan is to move it to yaml/json and per wiki file (T223602). In general, you should not use this files directly, use api.php sitematrix, sites, js config variables but this file is mostly for internal use only.

Anomie added a subscriber: Anomie.

@Aklapper added a project: Core Platform Team
I'm sad that the commit message does not offer [a link to] a rationale behind this change.

As far as I can tell, CPT had nothing to do with the change or anything else on T223602.

Is this a permanent thing?

No.

Dcljr added a comment.Sep 18 2019, 3:12 AM

In general, you should not use this files directly, use api.php sitematrix, sites, js config variables but this file is mostly for internal use only.

(FWIW) I will try to refer to API queries in the future when discussing wiki configuration.

Per T223602, this is only a transitional stage. Unless it's easy and worthwhile updating twice in a short period, I think we're better off leaving references as they are. Proposing to decline as such.

I mean, it's temporary that there's a file called VariantSettings and no (useful) file called InitialiseSettings, but it's also (slightly less) temporary that there'd be a file called InitialiseSettings again.

Krinkle closed this task as Declined.Sep 19 2019, 8:13 PM

Declining then. Short version: The code in VariantSettings will soon move back to InitialiseSettings. But beware that we're also planning to remove this file in general, so in a bit more time, this file won't exist. It'll instead be a directory of separate files.