Page MenuHomePhabricator
Create Task
Maniphest T233163

[mobile] Homepage modules overlays displayed cutoff
Closed, ResolvedPublic
Actions

Description

The issue is present with every Homepage mobile overlay - Start, Impact, Mentor. and Help modules. Below is a specific example for Help module.

  1. On a mobile device (or in a browser mobile emulator) go to Homepage and click on "Get help with editing".
  2. The overlay opens with the following element not visible in the viewport (on iPhone it can be scrolled down to view it).
<h3 class="growthexperiments-homepage-module-section growthexperiments-homepage-
module-section-subheader growthexperiments-homepage-module-subheader">Top help pages about editing</h3>

IMG_8316.PNG (1×640 px, 55 KB)

Details

SubjectRepoBranchLines +/-
Fix broken display of mobile overlay headingsmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.23+2 -1
Fix broken display of mobile overlay headingsmediawiki/extensions/GrowthExperimentsmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 17 2019, 9:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2019, 9:33 PM
Etonkovidova mentioned this in T232548: Homepage: remove question-asking from help module.Sep 17 2019, 9:48 PM
MMiller_WMF added a project: Growth-Team.Sep 17 2019, 10:46 PM
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 17 2019, 10:52 PM

This is a regression caused by T232548, and so we should solve it before deployed T232548.

Etonkovidova renamed this task from [wmf.23] "Top help pages about editing" header not visibleon mobile Help panel overlay to [wmf.23] "Top help pages about editing" header not visible on mobile Help panel overlay .Sep 17 2019, 11:29 PM
MMiller_WMF added subscribers: • marcella, Catrope, Tgr.Sep 23 2019, 10:29 PM

@Catrope @kostajh @Tgr @marcella @Etonkovidova -- I was just playing with this, and it looks to me like it extends to all modules, not just the help module. If that's the case, I think this is a high-priority bug fix, because it means that all mobile users can't see the top of any homepage modules once they open them.

@Etonkovidova -- can you confirm?

Etonkovidova renamed this task from [wmf.23] "Top help pages about editing" header not visible on mobile Help panel overlay to [mobile] Homepage modules overlays displayed cutoff .Sep 23 2019, 10:49 PM
Etonkovidova removed a project: Regression.
Etonkovidova updated the task description. (Show Details)
Catrope added a comment.Sep 24 2019, 12:30 AM

This appears to be a regression in MinervaNeue between wmf.22 and wmf.23.

Catrope added a comment.Sep 24 2019, 12:33 AM

git bisect blames rSMINd8deb264f2b5: Only apply padding-top to overlays with headers, which sounds quite plausible.

Catrope added a comment.Sep 24 2019, 12:38 AM

This happened because the change above moved the padding to make room for the header from the overlay div to the overlay-content div, and Special:Homepage already had a different padding rule on overlay-content, which overrode Minerva's new rule.

gerritbot added a comment.Sep 24 2019, 12:41 AM

Change 538723 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Fix broken display of mobile overlay headings

https://gerrit.wikimedia.org/r/538723

gerritbot added a project: Patch-For-Review.Sep 24 2019, 12:41 AM
Catrope claimed this task.Sep 24 2019, 12:41 AM
Catrope moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 24 2019, 7:56 AM
gerritbot added a comment.Sep 24 2019, 7:57 AM

Change 538788 had a related patch set uploaded (by Kosta Harlan; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.23] Fix broken display of mobile overlay headings

https://gerrit.wikimedia.org/r/538788

gerritbot added a comment.Sep 24 2019, 8:11 AM

Change 538723 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix broken display of mobile overlay headings

https://gerrit.wikimedia.org/r/538723

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 24 2019, 9:01 AM
gerritbot added a comment.Sep 24 2019, 11:20 AM

Change 538788 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.23] Fix broken display of mobile overlay headings

https://gerrit.wikimedia.org/r/538788

Stashbot added a comment.Sep 24 2019, 11:24 AM

Mentioned in SAL (#wikimedia-operations) [2019-09-24T11:24:35Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.23/extensions/GrowthExperiments/modules/homepage/ext.growthExperiments.Homepage.less: SWAT: rEGREd4c64a799c64: Fix broken display of mobile overlay headings (T233163) (duration: 00m 57s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.23; 2019-09-17); removed MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 24 2019, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2019, 12:11 PM
Etonkovidova moved this task from QA to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 24 2019, 4:22 PM

@MMiller_WMF - the fix is in place; I checked in betalabs and will check after deployment (it should be backported to wmf.23).

MMiller_WMF closed this task as Resolved.Sep 24 2019, 5:09 PM

Thank you for the quick fix @Catrope @kostajh @Etonkovidova! This looks good to me in production.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits