PHP Notice: Undefined property: stdClass::$page_namespace
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.1

message

PHP Notice: Undefined property: stdClass::$page_namespace

Notes

Appears to be a new regression in 1.35.0-wmf.1.
355 reports in the last hour alone (or ~60% of production MW errors)

Details

Request ID: XaFZKwpAEDYAAFtfVvQAAABM
Request URL: /w/api.php?action=query&prop=linkshere&lhprop=pageid&lhnamespace=0&lhlimit=10&pageids=333424&format=json

Stack Trace

exception.trace

#0 /includes/api/ApiQueryBase.php(596): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /includes/api/ApiQueryBacklinksprop.php(289): ApiQueryBase->executeGenderCacheFromResultWrapper(Wikimedia\Rdbms\ResultWrapper, string)
#2 /includes/api/ApiQueryBacklinksprop.php(83): ApiQueryBacklinksprop->run()
#3 /includes/api/ApiQuery.php(255): ApiQueryBacklinksprop->execute()
#4 /includes/api/ApiMain.php(1588): ApiQuery->execute()
#5 /includes/api/ApiMain.php(537): ApiMain->executeAction()
#6 /includes/api/ApiMain.php(508): ApiMain->executeActionWithErrorHandling()
#7 /api.php(83): ApiMain->execute()
#8 /srv/mediawiki/w/api.php(3): require(string)
#9 {main}

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Revert "Fill GenderCache for used pages in action=query&prop=fileusage"	Reedy	mediawiki/core	master	+0 -39
Run executeGenderCacheFromResultWrapper with titles in prop=linkshere	Reedy	mediawiki/core	REL1_34	+3 -1
Run executeGenderCacheFromResultWrapper with titles in prop=linkshere	Umherirrender	mediawiki/core	master	+3 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T233850 1.35.0-wmf.2 deployment blockers
		Resolved	PRODUCTION ERROR	Umherirrender	T235316 PHP Notice: Undefined property: stdClass::$page_namespace

Event Timeline

Krinkle created this task.Oct 12 2019, 4:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2019, 4:46 AM

Seems related to:

/cc @Umherirrender, @Anomie.

Krinkle updated the task description. (Show Details)Oct 12 2019, 4:48 AM

Change 542663 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Run executeGenderCacheFromResultWrapper with titles in prop=linkshere

https://gerrit.wikimedia.org/r/542663

gerritbot added a project: Patch-For-Review.Oct 12 2019, 8:40 AM

lhprop=pageid skipps the addition of necessary fields to the result set, added a condition for that

Umherirrender mentioned this in T235334: ErrorException from line 596 of /srv/mediawiki/php-1.35.0-wmf.1/includes/api/ApiQueryBase.php: PHP Notice: Undefined property: stdClass::$page_namespace.Oct 12 2019, 4:09 PM

In T235334#5569931, @Reedy wrote:

Reverting out of 1.35.0-wmf.1 (for now), due to ~240K errors in 90 minutes on enwiki

In T235334#5569979, @gerritbot wrote:

Change 542687 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.1] Revert "Fill GenderCache for used pages in action=query&prop=fileusage"

https://gerrit.wikimedia.org/r/542687

Change 542686 had a related patch set uploaded (by Krinkle; owner: Reedy):
[mediawiki/core@master] Revert "Fill GenderCache for used pages in action=query&prop=fileusage"

https://gerrit.wikimedia.org/r/542686

Reverted out of wmf.1 locally. Before wmf.2 is branched, it should either be fixed or reverted in master as well. Tagging as blocker to remember that.

Anomie moved this task from Inbox to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Oct 14 2019, 12:27 PM

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.

Change 542917 had a related patch set uploaded (by Reedy; owner: Umherirrender):
[mediawiki/core@REL1_34] Run executeGenderCacheFromResultWrapper with titles in prop=linkshere

https://gerrit.wikimedia.org/r/542917

Change 542663 merged by jenkins-bot:
[mediawiki/core@master] Run executeGenderCacheFromResultWrapper with titles in prop=linkshere

https://gerrit.wikimedia.org/r/542663

Change 542917 merged by jenkins-bot:
[mediawiki/core@REL1_34] Run executeGenderCacheFromResultWrapper with titles in prop=linkshere

https://gerrit.wikimedia.org/r/542917

ReleaseTaggerBot added projects: MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 14 2019, 1:00 PM

Reedy closed this task as Resolved.Oct 14 2019, 2:02 PM

Change 542686 abandoned by Reedy:
Revert "Fill GenderCache for used pages in action=query&prop=fileusage"

Reason:
No longer needed, fix patch is merged

https://gerrit.wikimedia.org/r/542686

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2019, 2:10 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM

PHP Notice: Undefined property: stdClass::$page_namespaceClosed, ResolvedPublicPRODUCTION ERRORActions