Page MenuHomePhabricator

scrollbar breaks the modal
Closed, ResolvedPublic3 Story PointsBUG REPORT

Description

Steps to Reproduce:
open the bridge in beta, minimize the height of the window to force the modal to shrink so we get a scrollbar.

Actual Results:
the scrollbar is pertruding too far to the right and too high up and is scrolling away the sticky header.


Expected Results:
it should not go into the header but be below the header (see mocks for reference) and it should not scroll away the sticky header.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: add scrollbar to body

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 16 2019, 10:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

"underneath" (on a layer under) vs. "below" (south of)?

South of, I assume – that is, only the content excluding the header should be scrollable.

That is my interpretation as well, but @Charlie_WMDE calls the shots.

Hey, sorry for the clumsy phrasing. You're both correct in your interpretation.

WMDE-leszek updated the task description. (Show Details)Tue, Oct 22, 9:26 AM
Charlie_WMDE updated the task description. (Show Details)Tue, Oct 22, 9:26 AM
WMDE-leszek set the point value for this task to 3.Tue, Oct 22, 9:31 AM
Charlie_WMDE updated the task description. (Show Details)Tue, Oct 22, 9:32 AM

Change 546942 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add scrollbar to body

https://gerrit.wikimedia.org/r/546942

Change 546942 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add scrollbar to body

https://gerrit.wikimedia.org/r/546942

darthmon_wmde closed this task as Resolved.Wed, Nov 6, 9:34 AM
darthmon_wmde moved this task from Verification to Done on the Wikidata-Bridge-Sprint-8 board.