Page MenuHomePhabricator
Create Task
Maniphest T235055

Create progressive disabled version of save button
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
bridge: Create progressive disabled version of save buttonmediawiki/extensions/Wikibasemaster+103 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 9 2019, 10:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:44 AM
Michael claimed this task.Oct 15 2019, 4:41 PM
Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-7 board.
Michael added a project: User-Michael.
Michael added a comment.Oct 16 2019, 10:35 AM

While working on this ticket a bug in @vue/test-utils was noticed and reported: https://github.com/vuejs/vue-test-utils/issues/1321
This bug could lead to falsely green tickets.

gerritbot added a comment.Oct 16 2019, 11:48 AM

Change 543405 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Create progressive disabled version of save button

https://gerrit.wikimedia.org/r/543405

gerritbot added a project: Patch-For-Review.Oct 16 2019, 11:48 AM
Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.Oct 16 2019, 12:11 PM
Michael moved this task from 🗃️ Incoming to 💬 waiting on other's work or feedback on the User-Michael board.
gerritbot added a comment.Oct 16 2019, 3:04 PM

Change 543405 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Create progressive disabled version of save button

https://gerrit.wikimedia.org/r/543405

Michael closed this task as Resolved.Oct 16 2019, 3:28 PM
Michael moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 16 2019, 4:00 PM
Lucas_Werkmeister_WMDE added a comment.Oct 16 2019, 4:02 PM

Shouldn’t this go into the Verification column for UX to review the button?

Michael reopened this task as Open.Oct 16 2019, 4:43 PM
Michael moved this task from Done to Verification on the Wikidata-Bridge-Sprint-7 board.
In T235055#5580471, @Lucas_Werkmeister_WMDE wrote:

Shouldn’t this go into the Verification column for UX to review the button?

So far my understanding was that mainly stories should go into verification, but moving this there makes sense as well.

However, I failed to get the hosted storybook to update :/

It seems there is some problem with not enough resources being available?

tools.wikibase-databridge-storybook@tools-sgebastion-07:~/Wikibase/client/data-bridge$ ./node_modules/@storybook/vue/bin/build.js -o ~/www/static
info @storybook/vue v5.1.11
info 
info clean outputDir..
info => Copying prebuild dll's..
info => Building manager..
info => Loading manager config..
info => Loading presets
info => Loading custom addons config.
info => Compiling manager..
info => manager built (1.02 min)
info => Building preview..
info => Loading preview config..
info => Loading presets
info => Loading custom webpack config (full-control mode).
info => Compiling preview..
Starting type checking service...
Using 1 worker with 2048MB memory limit
92% chunk asset optimization TerserPluginnode[23253]: pthread_create: Resource temporarily unavailable
node[23247]: pthread_create: Resource temporarily unavailable
/mnt/nfs/labstore-secondary-tools-project/wikibase-databridge-storybook/Wikibase/client/data-bridge/node_modules/worker-farm/lib/fork.js:23
  child.send({ owner: 'farm', module: forkModule })
        ^

TypeError: child.send is not a function
    at fork (/mnt/nfs/labstore-secondary-tools-project/wikibase-databridge-storybook/Wikibase/client/data-bridge/node_modules/worker-farm/lib/fork.js:23:9)
    at Farm.startChild (/mnt/nfs/labstore-secondary-tools-project/wikibase-databridge-storybook/Wikibase/client/data-bridge/node_modules/worker-farm/lib/farm.js:107:16)
    at Farm.processQueue (/mnt/nfs/labstore-secondary-tools-project/wikibase-databridge-storybook/Wikibase/client/data-bridge/node_modules/worker-farm/lib/farm.js:288:10)
    at Farm.receive (/mnt/nfs/labstore-secondary-tools-project/wikibase-databridge-storybook/Wikibase/client/data-bridge/node_modules/worker-farm/lib/farm.js:213:8)
    at Farm.<anonymous> (/mnt/nfs/labstore-secondary-tools-project/wikibase-databridge-storybook/Wikibase/client/data-bridge/node_modules/worker-farm/lib/farm.js:123:10)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at emit (internal/child_process.js:772:12)
    at _combinedTickCallback (internal/process/next_tick.js:141:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

The cause seems to be: node[23247]: pthread_create: Resource temporarily unavailable

Michael moved this task from Verification to Peer Review on the Wikidata-Bridge-Sprint-7 board.Oct 16 2019, 4:43 PM
Lucas_Werkmeister_WMDE added a comment.Oct 16 2019, 5:58 PM

Same problem here, I couldn’t get it to work (using jsub didn’t help either). For now I’d hope that it’s a temporary problem with Toolforge, and retry later?

Stashbot added a comment.Oct 17 2019, 12:30 PM

Mentioned in SAL (#wikimedia-cloud) [2019-10-17T12:30:12Z] <Lucas_WMDE> $ npm run build-storybook && tar -C storybook-static -c . | ssh toolforge "sudo -i -u tools.wikibase-databridge-storybook sh -c 'rm -rf www/static/*; tar -C www/static/ -x'" # deploy locally built storybook (T235055)

Michael moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-7 board.Oct 17 2019, 12:38 PM
Michael added a subscriber: Charlie_WMDE.Oct 17 2019, 12:40 PM

Thank you, @Lucas_Werkmeister_WMDE, for making a current version of the storybook available again :)

@Charlie_WMDE You can see the disabled version of the button there: https://tools-static.wmflabs.org/wikibase-databridge-storybook/?path=/story/eventemittingbutton--primaryprogressive-disabled

Lucas_Werkmeister_WMDE mentioned this in T235763: Investigate broken Wikidata Bridge Storybook updates.Oct 17 2019, 2:11 PM

I created T235763: Investigate broken Wikidata Bridge Storybook updates for looking into the broken storybook further.

Lydia_Pintscher subscribed.Oct 17 2019, 5:39 PM

@Charlie_WMDE please close when you had a look :)

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:28 PM
Charlie_WMDE added a comment.Oct 22 2019, 10:01 AM

@Lucas_Werkmeister_WMDE @Michael

According to the inspector the button seems to have a height of 36.7px. would that automatically adjust itself to 40px when placed in the header? Because that's the height it would need to have in the end.

Michael added a comment.Oct 22 2019, 10:03 AM
In T235055#5594302, @Charlie_WMDE wrote:

@Lucas_Werkmeister_WMDE @Michael

According to the inspector the button seems to have a height of 36.7px. would that automatically adjust itself to 40px when placed in the header? Because that's the height it would need to have in the end.

Yeah, it will be the correct size in the header in a browser with a default font-size of 16.

Charlie_WMDE added a comment.Oct 22 2019, 10:04 AM

coolio! then it all looks good \o/

Charlie_WMDE closed this task as Resolved.Oct 22 2019, 10:05 AM
Charlie_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-7 board.
Lucas_Werkmeister_WMDE added a comment.Oct 22 2019, 10:05 AM

I think so, yes (it would take on the full height of the header, as we already saw in T235622/T235623).

If we close this ticket, we can still add a note to the parent task to make the height part of its verification.

Charlie_WMDE added a comment.Oct 22 2019, 10:28 AM

sounds good! thank you lucas.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits