Page MenuHomePhabricator
Create Task
Maniphest T236112

Missing contentmodel handlers for everything but wikitext
Open, LowPublic
Actions

Description

  1. PHP Notice: Undefined index: proofread-page on URL: it.wikisource.org/v3/page/html/Pagina%3AKant_-_Considerazioni_sul_sentimento_del_sublime_e_del_bello%2C_Napoli%2C_1826.djvu%2F14/1831689
  2. PHP Notice: Undefined index: javascript on URL: en.wikipedia.org/v3/page/html/User%3ADanski454%2FWikiStatus.js/865585677

... and so on for Scribunto, proofread-index

#0 /srv/deployment/parsoid/deploy-cache/revs/a6da34c1550a15285b629c72d889836476f9e7bd/src/src/Config/SiteConfig.php(946): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/deployment/parsoid/deploy-cache/revs/a6da34c1550a15285b629c72d889836476f9e7bd/src/src/Config/Env.php(777): Parsoid\Config\SiteConfig->getContentModelHandler(string)
#2 /srv/deployment/parsoid/deploy-cache/revs/a6da34c1550a15285b629c72d889836476f9e7bd/src/src/Parsoid.php(55): Parsoid\Config\Env->getContentHandler()
#3 /srv/deployment/parsoid/deploy-cache/revs/a6da34c1550a15285b629c72d889836476f9e7bd/src/src/Parsoid.php(77): Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#4 /srv/deployment/parsoid/deploy-cache/revs/a6da34c1550a15285b629c72d889836476f9e7bd/src/extension/src/Rest/Handler/ParsoidHandler.php(427): Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array)
#5 /srv/deployment/parsoid/deploy-cache/revs/a6da34c1550a15285b629c72d889836476f9e7bd/src/extension/src/Rest/Handler/PageHandler.php(41): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(Parsoid\Config\Env, array)
#6 /srv/mediawiki/php-1.35.0-wmf.2/includes/Rest/Router.php(306): MWParsoid\Rest\Handler\PageHandler->execute()
#7 /srv/mediawiki/php-1.35.0-wmf.2/includes/Rest/Router.php(285): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#8 /srv/mediawiki/php-1.35.0-wmf.2/includes/Rest/EntryPoint.php(116): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#9 /srv/mediawiki/php-1.35.0-wmf.2/includes/Rest/EntryPoint.php(83): MediaWiki\Rest\EntryPoint->execute()
#10 /srv/mediawiki/php-1.35.0-wmf.2/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#11 /srv/mediawiki/w/rest.php(3): require(string)
#12 {main}

Details

SubjectRepoBranchLines +/-
Work around missing support for non-wikitext content modelsmediawiki/services/parsoidmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

ssastry triaged this task as High priority.Oct 21 2019, 11:35 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2019, 11:35 PM
ssastry moved this task from Backlog to Bugs, Notices, Crashers on the Parsoid-PHP board.Oct 21 2019, 11:39 PM
cscott subscribed.Oct 22 2019, 1:32 AM

Probably missing implementations of the JSON and ProofRead page extensions...

gerritbot added a comment.Oct 29 2019, 9:25 PM

Change 547046 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Work around missing support for non-wikitext content models

https://gerrit.wikimedia.org/r/547046

gerritbot added a project: Patch-For-Review.Oct 29 2019, 9:25 PM
gerritbot added a comment.Oct 29 2019, 9:44 PM

Change 547046 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Work around missing support for non-wikitext content models

https://gerrit.wikimedia.org/r/547046

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2019, 10:11 PM
ssastry lowered the priority of this task from High to Low.Oct 30 2019, 3:16 AM
ssastry moved this task from Bugs, Notices, Crashers to Post-Port Work on the Parsoid-PHP board.
brennen subscribed.Oct 30 2019, 7:42 PM

This class of error has led to a lot of noise while tailing logs during this week's train deploy:

brennen@mwlog1001:/srv/mw-log$ grep -c 'SiteConfig.*index' error.log                                                                                                                                                                                                           
186830

...for a log starting at 2019-10-30 08:03:07.

ssastry added a comment.Oct 30 2019, 7:44 PM
In T236112#5621040, @brennen wrote:

This class of error has led to a lot of noise while tailing logs during this week's train deploy:

brennen@mwlog1001:/srv/mw-log$ grep -c 'SiteConfig.*index' error.log                                                                                                                                                                                                           
186830

...for a log starting at 2019-10-30 08:03:07.

Indeed. We have a fix for this and one other noisy bug and we are going to deploy those changes in 15 mins.

brennen added a comment.Oct 30 2019, 7:54 PM

Beautiful, thanks!

Stashbot mentioned this in T235656: Ref fragments remain unexpanded in Image:Frameless, mw:ExpandedAttrs, mw:LanguageVariant nodes.Oct 30 2019, 8:42 PM
Stashbot mentioned this in T233818: Call to a member function getContent() on null.
Stashbot mentioned this in T234549: "Properly" address missing srcText issues in PageConfigFrame / missing revID in REST API.
Stashbot mentioned this in T227209: Security Review For Parsoid-PHP.

Mentioned in SAL (#wikimedia-operations) [2019-10-30T20:42:45Z] <arlolra> Updated Parsoid to 5ac1623 (T235656, T233818, T234549, T227209, T236112)

ssastry moved this task from Post-Port Work to Porting on the Parsoid-PHP board.Dec 8 2019, 3:22 AM
Arlolra mentioned this in T228217: Ensure all the features of parse.js are covered by parse.php.Dec 20 2019, 12:19 AM
ssastry edited projects, added Parsoid; removed Parsoid-PHP.Feb 28 2020, 9:17 PM
ssastry moved this task from Needs Triage to Missing Functionality on the Parsoid board.Feb 28 2020, 10:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits