Implement and set up tracker in init module
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Oct 23 2019, 9:44 AM

Description

Create an implementation that calls mw.track (documentation) and save it in the services we pass into the app.

See T236233 for the final name of the interface to be implemented.

Details

	Subject	Repo	Branch	Lines +/-
	bridge: Implement track service	mediawiki/extensions/Wikibase	master	+132 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T231204 track Bridge openings by property datatype
		Resolved		• Matthias_Geisler_WMDE	T236235 Implement and set up tracker in init module

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 23 2019, 9:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2019, 9:44 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 23 2019, 10:04 AM

Just a question regarding 3rd parties, which are not using Graphite. Do we make Graphite as a dependency now, or we wanna try to make this feature some how not effective if it's (Graphite) not enabled/available?

In T236235#5598552, @Matthias_Geisler_WMDE wrote:

Just a question regarding 3rd parties, which are not using Graphite. Do we make Graphite as a dependency now, or we wanna try to make this feature some how not effective if it's (Graphite) not enabled/available?

I'd say we just use mw.track (which is in core) and let each installation decide how they want to handle the data there. In the case of Wikipedia, it seems there is an extra extension that is subscribed to these events and then submits them to our graphite instance.

Maybe the topic could be something like counter.Wikibase.DataBridge.datatype.string ?

I would suggest counter.MediaWiki.wikibase.client.databridge.datatype.string, for consistency with some other things tracked in Wikibase. (Note that the MediaWiki part is added automatically when logging from PHP, but in JS we have to add it ourselves.)

In T236235#5598946, @Lucas_Werkmeister_WMDE wrote:

I would suggest counter.MediaWiki.wikibase.client.databridge.datatype.string, for consistency with some other things tracked in Wikibase. (Note that the MediaWiki part is added automatically when logging from PHP, but in JS we have to add it ourselves.)

👍

• Matthias_Geisler_WMDE claimed this task.Oct 23 2019, 4:16 PM

• Matthias_Geisler_WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-8 board.

Change 545610 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Implement track service

https://gerrit.wikimedia.org/r/545610

gerritbot added a project: Patch-For-Review.Oct 23 2019, 4:17 PM

Change 545610 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Implement track service

https://gerrit.wikimedia.org/r/545610

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2019, 12:10 PM

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-8 board.Oct 30 2019, 12:27 PM

• Pablo-WMDE closed this task as Resolved.Oct 31 2019, 10:49 AM