Page MenuHomePhabricator

Implement and set up tracker in init module
Closed, ResolvedPublic

Description

Create an implementation that calls mw.track (documentation) and save it in the services we pass into the app.

See T236233 for the final name of the interface to be implemented.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: Implement track service

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2019, 9:44 AM

Just a question regarding 3rd parties, which are not using Graphite. Do we make Graphite as a dependency now, or we wanna try to make this feature some how not effective if it's (Graphite) not enabled/available?

Just a question regarding 3rd parties, which are not using Graphite. Do we make Graphite as a dependency now, or we wanna try to make this feature some how not effective if it's (Graphite) not enabled/available?

I'd say we just use mw.track (which is in core) and let each installation decide how they want to handle the data there. In the case of Wikipedia, it seems there is an extra extension that is subscribed to these events and then submits them to our graphite instance.

Maybe the topic could be something like counter.Wikibase.DataBridge.datatype.string ?

I would suggest counter.MediaWiki.wikibase.client.databridge.datatype.string, for consistency with some other things tracked in Wikibase. (Note that the MediaWiki part is added automatically when logging from PHP, but in JS we have to add it ourselves.)

I would suggest counter.MediaWiki.wikibase.client.databridge.datatype.string, for consistency with some other things tracked in Wikibase. (Note that the MediaWiki part is added automatically when logging from PHP, but in JS we have to add it ourselves.)

👍

Change 545610 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Implement track service

https://gerrit.wikimedia.org/r/545610

Change 545610 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Implement track service

https://gerrit.wikimedia.org/r/545610

Pablo-WMDE closed this task as Resolved.Oct 31 2019, 10:49 AM