Page MenuHomePhabricator
Create Task
Maniphest T236850

Test out Fundraising-related cookies with SameSite/Secure cookie behaviour in Chrome 80 simulation
Open, Needs TriagePublic
Actions

Description

Following on from the discussion here test out the options available and size the work (if any) to be done.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Set banner hide cookies to Secure / SameSite=NoneEjeggmediawiki/extensions/CentralNoticemaster+8 -5
Set banner hide cookies to Secure / SameSite=NoneEjeggmediawiki/extensions/CentralNoticemaster+8 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

jgleeson created this task.Oct 29 2019, 9:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 9:30 PM
jgleeson updated the task description. (Show Details)Oct 29 2019, 9:30 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Nov 1 2019, 3:05 PM
Tgr mentioned this in T158604: Investigate usefulness of SameSite cookies for logged-in accounts.Jan 4 2020, 11:55 PM
• DStrine moved this task from Sprint +1 to Next on the Fundraising-Backlog board.Jan 6 2020, 4:44 PM
• DStrine moved this task from Next to Q3 2021-2022 on the Fundraising-Backlog board.Mar 3 2020, 3:58 PM
Tgr added a parent task: T255366: SameSite cookie issues.Jun 14 2020, 11:49 AM
Krinkle renamed this task from Test out SameSite & Secure cookie behaviour in Chrome 80 Simulation to Test out Fundraising-related cookies with SameSite/Secure cookie behaviour in Chrome 80 simulation.Jun 14 2020, 3:49 PM
Tgr subscribed.Jul 14 2020, 3:46 PM

Chrome is rolling out SameSite=Lax by default today. rMWf8a7a1ace825: Support SameSite=None cookies has added support for a sameSite flag in WebResponse::setCookie so updating Special:HideBanner should be relatively straightforward. Handling it on the JS side is less trivial for now (see T257936: Support the WebRequest / WebResponse SameSite behavior on the JS side).

mdaniels5757 subscribed.Jul 24 2020, 4:55 PM
XenoRyet moved this task from Q3 2021-2022 to Unscheduled on the Fundraising-Backlog board.Mar 14 2023, 10:14 PM
mdaniels5757 unsubscribed.Mar 14 2023, 10:35 PM
gerritbot added a comment.Aug 19 2025, 4:03 PM

Change #1180165 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/CentralNotice@master] Set banner hide cookies to Secure / SameSite=None

https://gerrit.wikimedia.org/r/1180165

gerritbot added a project: Patch-For-Review.Aug 19 2025, 4:04 PM
gerritbot added a comment.Aug 21 2025, 4:15 PM

Change #1180165 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Set banner hide cookies to Secure / SameSite=None

https://gerrit.wikimedia.org/r/1180165

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2025, 4:32 PM
gerritbot added a comment.Sep 9 2025, 10:12 PM

Change #1186618 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/CentralNotice@master] Set banner hide cookies to Secure / SameSite=None

https://gerrit.wikimedia.org/r/1186618

gerritbot added a project: Patch-For-Review.Sep 9 2025, 10:12 PM
gerritbot added a comment.Sep 10 2025, 5:59 PM

Change #1186618 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Set banner hide cookies to Secure / SameSite=None

https://gerrit.wikimedia.org/r/1186618

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 10 2025, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 10 2025, 6:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits