I did some debugging by creating a test user as mentioned in the bug report and doing different workflows. For the new user, the suggestions never showed up, untill I created a draft translation. This concludes that
the logic in isPotentialTranslator is not returning true for new user.

private static function isPotentialTranslator( User $user ) {
		if ( Translator::isTranslator( $user ) ) {
			// Already a translator
			return true;
		}

		if ( ExtensionRegistry::getInstance()->isLoaded( 'CentralAuth' ) ) {
			$centralUser = CentralAuthUser::newFromId( $user->getId() );
			if ( !$centralUser ) {
				// No user exists with that id
				return false;
			}

			// Check if the user has edited in more than one wiki.
			$editedWikiCount = 0;
			$attachedAccounts = $centralUser->queryAttached();
			foreach ( $attachedAccounts as $account ) {
				if (
					// Ignore non-wikipedia wikis such as commons, mediawiki, meta etc
					// url property example "https://commons.wikimedia.org",
					strpos( $account['url'] ?? '', 'wikipedia' ) !== false &&
					intval( $account['editCount'] ?? 0 ) > 0
				) {
					$editedWikiCount++;
					break;
				}
			}
			if ( $editedWikiCount === 0 ) {
				return false;
			}
		}

		return true;
	}

This means, if Translator::isTranslator( $user ) is returning true, everything works fine. If not, the rest of the logic in the code is not able to return true for new user. The good news is we know what part of the code is faulty for new users. Bad news is debugging with centralauth is not easy in our local development machines.

Change 556522 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] isPotentialTranslator: Fix the editCount and wiki validation

https://gerrit.wikimedia.org/r/556522

Change 556522 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] isPotentialTranslator: Fix the editCount and wiki validation

https://gerrit.wikimedia.org/r/556522

@santhosh currently, if I

1. create a new user on jv.wikipedia.org
2. change it's language from javanese to english
3. go to jv.wikipedia.org/w/index.php?title=Paneer&action=edit and close the visual editor popup
4. go to jv.wikipedia.org/w/index.php?title=Paneer&action=edit

I get the specific invite with the Paneer article in English.
This behaviour is expected and was not working before.

BUT...

If I

1. create a new user on jv.wikipedia.org
2. change it's language from javanese to english
3. go to jv.wikipedia.org/w/index.php?title=randomArticle&action=edit and close the visual editor popup
4. go to jv.wikipedia.org/w/index.php?title=randomArticle&action=edit

I should get the generic invite, but nothing appears.

In T237607#5788191, @Jpita wrote:

I should get the generic invite, but nothing appears.

That 4 steps in this comment looks same in both cases to my eyes. So, confused.

I forgot to change the text of the 2nd case links, updated the comment now.
On the 2nd case the article does not exist in another language

Generic invite is supposed to show only once and only for the user having no translations yet. Can you help me getting the following code executed for the second case in browser console?

>> mw.config.get( 'wgContentTranslationExistingTranslator' )
true
>> mw.config.get( 'wgContentTranslationNewByTranslationShown' )
"true"

If both value are true, no invites are shown. But if the user is new, both these values are supposed to be false.
In any case, if this issue is present, it is not part of this ticket, probably the parent ticket.

I just tried with a brand new user, not changing the language and going to https://jv.wikipedia.org/w/index.php?title=Paneer&action=edit and the special invite is showing.
I believe this is not supposed to be happening.
the results of your query are:

mw.config.get( 'wgContentTranslationExistingTranslator' )
false
mw.config.get( 'wgContentTranslationNewByTranslationShown' )
"true"

In summary:
There are 2 issues:

1. The generic invite is not showing
2. The specific invite is always showing, even for non-multilingual users

Are these issues going to be fixed here or should I create other tickets?

Change 564392 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Fix the default result of isPotentialTranslator

https://gerrit.wikimedia.org/r/564392

Change 564392 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix the default result of isPotentialTranslator

https://gerrit.wikimedia.org/r/564392

@KartikMistry how can I know when this is going to be deployed?
the tag on the tag (wmf11) doesn't have the latest code

In T237607#5803710, @Jpita wrote:

@KartikMistry how can I know when this is going to be deployed?
the tag on the tag (wmf11) doesn't have the latest code

This will be available with wmf.15 (ie on Friday for all Wikis): https://www.mediawiki.org/wiki/MediaWiki_1.35/wmf.15#ContentTranslation

New user created on jv.wiki:

Steps:

• New user goes to paneer in edit mode after changing language to English
  • OK - NO invite
• New user goes to paneer in edit mode after after going to other wiki
  • OK - NO invite
• New user goes to paneer in edit mode after after editing other wiki
  • OK - NO invite
• New user goes to paneer in edit mode after after editing jv wiki
  • ERROR - NO invite - Invite should show now according to T232372 and T223888

user info:
https://gist.github.com/jpita/ebebab16648441b5c909903a5e0f1767

mw.config.get( 'wgContentTranslationExistingTranslator' )
null
mw.config.get( 'wgContentTranslationNewByTranslationShown' )
null

Change 569935 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Hooks: Fix CentralAuth user instance calculation

https://gerrit.wikimedia.org/r/569935

Change 569935 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Hooks: Fix CentralAuth user instance calculation

https://gerrit.wikimedia.org/r/569935

Still not working.

Change 573064 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Fix impossible condition in Hooks:isPotentialTranslator

https://gerrit.wikimedia.org/r/573064

Change 573064 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix impossible condition in Hooks:isPotentialTranslator

https://gerrit.wikimedia.org/r/573064