Syntax highlighting moves cursor out from the actual writing place when using New Wikitext Mode at euwiki
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Theklan
	Nov 19 2019, 6:30 PM

Description

Steps to Reproduce:

Take an article (for example, https://eu.wikipedia.org/wiki/Dodo#Geratzen_diren_arrastoak ).
Enable "New wikitext mode" on https://eu.wikipedia.org/wiki/Speciala%C4%B5o:Preferoj#mw-prefsection-betafeatures
Click to change code with the New Wikitext Mode enabled
From the dropdown in the right upper corner, choose "Syntax highlighter".

Actual Results:
(look how the red underline is not below the actual word)

Expected Results:
(look how the red underline is below the word)

Details

	Subject	Repo	Branch	Lines +/-
	VE: Update padding to match VisualEditor changes	mediawiki/extensions/CodeMirror	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: T290251: Review CodeMirror tickets about cursor position/text selections being misaligned
T212680: Cursor off by several lines where the text is edited in new wikitext mode

Event Timeline

Theklan created this task.Nov 19 2019, 6:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2019, 6:30 PM

Theklan added projects: VisualEditor, SyntaxHighlight.Nov 19 2019, 7:53 PM

Aklapper updated the task description. (Show Details)Nov 25 2019, 3:58 AM

Aklapper updated the task description. (Show Details)Nov 25 2019, 4:00 AM

Aklapper updated the task description. (Show Details)

@Theklan, Hi! How is the underlining bug in the task description related to the "cursor" mentioned in the task summary?

If this task is about the position red underline, that is done by your (unmentioned) browser I think...?

No, the red underline is a guide of where the cursor should be in relation with the word. I have tried with Firefox and Chrome, logged in and out, deleting my cookies, with a secret mode tab and also from another computer, with the same results.

Thanks for creating this task @Theklan, at this time the Editing-team can not prioritize fixing this bug.

@JTannerWMF moved this task from To Triage to Freezer on the VisualEditor board.

At the time, we assumed this is yet another of the syntax highlighting bugs which are impossible to fix (without a big rewrite) due to how the "real" surface and the syntax-highlighted surface are displayed.

But today I noticed this problem myself when editing an article, while I could never reproduce the other issues, so I decided to have a closer look.

This is actually a regression from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/536371. Apparently the "negligible difference" of 0.3333 pixels of padding is enough to cause this misalignment :D and we never updated the styles for the syntax-highlighted surface to apply the same padding change.

Change 557018 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/CodeMirror@master] VE: Update padding to match VisualEditor changes

https://gerrit.wikimedia.org/r/557018

gerritbot added a project: Patch-For-Review.Dec 13 2019, 1:32 PM

matmarex mentioned this in T212680: Cursor off by several lines where the text is edited in new wikitext mode.Dec 13 2019, 1:33 PM

Jolek subscribed.Dec 13 2019, 2:58 PM

Change 557018 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] VE: Update padding to match VisualEditor changes

https://gerrit.wikimedia.org/r/557018

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 5:10 PM

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Dec 13 2019, 5:13 PM

matmarex updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 13 2019, 6:01 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Dec 13 2019, 11:47 PM

Ryasmeen added a subscriber: Verified.