Remove pre-MCR schema fields during update
Closed, ResolvedPublic
Actions

Description

Tasks:

stop creating pre-MCR fields on new installs
remove rev_text_id, rev_content_model, and rev_content_format (and the corresponding fields in archive) from tables.sql
make SQL updater drop rev_text_id, rev_content_model, and rev_content_format (and the corresponding fields in archive) after populating the slots and content tables.

This is targeted to be complete for the MediaWiki 1.35 release.

Details

Subject	Repo	Branch	Lines +/-
MCR tests: override archive table schema	mediawiki/core	master	+30 -1
Stop creating pre-MCR fields on new installs	mediawiki/core	master	+4 -56
MCR tests: drop MCR fields when testing old schema	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T231668 MCR schema migration
Resolved	Zabe	T231674 [Epic] Remove support for writing to the pre-MCR schema
Resolved	daniel	T238958 Remove pre-MCR schema fields during update

Event Timeline

CCicalese_WMF created this task.Nov 22 2019, 10:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2019, 10:18 PM

CCicalese_WMF triaged this task as Medium priority.Nov 22 2019, 10:18 PM

CCicalese_WMF renamed this task from Remove pre-MCR schema fields from database to Remove pre-MCR schema fields.Nov 22 2019, 11:16 PM

Change 549903 had a related patch set uploaded (by Cicalese; owner: Daniel Kinzler):
[mediawiki/core@master] Stop creating pre-MCR fields on new installs

https://gerrit.wikimedia.org/r/549903

gerritbot added a project: Patch-For-Review.Nov 22 2019, 11:19 PM

daniel renamed this task from Remove pre-MCR schema fields to Remove pre-MCR schema fields during update.Nov 25 2019, 1:55 PM

daniel updated the task description. (Show Details)

Duplicate of T184615: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table?

Change 553195 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] MCR tests: drop MCR fields when testing old schema

https://gerrit.wikimedia.org/r/553195

Change 553196 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] MCR tests: override archive table schema

https://gerrit.wikimedia.org/r/553196

In T238958#5690070, @Anomie wrote:

Duplicate of T184615: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table?

Actually, I think T238966: Apply updates for MCR, actor migration, and content migration, to production wikis. is closer to T184615: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table. I will merge them. Thanks for finding that.