Page MenuHomePhabricator
Create Task
Maniphest T184615

Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table
Closed, DuplicatePublic
Actions

Description

Per https://www.mediawiki.org/wiki/Multi-Content_Revisions/Database_Schema#revision.

Note that the Wikimedia schema changes called for by this task should be combined with those in T215466: Remove revision_comment_temp and revision_actor_temp step 1.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+273 -157Alter `revision` for actor, comment, and MCR
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolveddanielT161671 Compacting the revision table
 DuplicateNoneT184615 Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table
 ResolveddanielT174044 Deploy MCR storage layer
 ResolveddanielT174023 Implement MCR storage layer
 ResolveddanielT174024 Implement MCR revision retrieval interface
 ResolveddanielT174025 Implement MCR revision retrieval legacy version
 ResolvedAnomieT166732 Refactor comment storage in the database and abstract access in MediaWiki
 ResolvedNoneT166798 Decide whether back-compat views for upcoming major schema changes will be provided in the Labs replicas
 DuplicateNoneT232531 Refactor Comment fields for CheckUser Component
 ResolvedAddshoreT188518 Implement Storage service for content models and slot roles
 ResolveddanielT189004 replace slot_inherited with slot_origin
 ResolvedAddshoreT188741 MCR Scheme change - Make rev_text_id DEFAULT 0
 ResolvedMarosteguiT190148 Change DEFAULT 0 for rev_text_id on production DBs
 ResolvedTgrT187586 Installer fails in RevisionStore
 ResolvedTgrT196653 Test MCR Storage Layer Patches
 ResolvedTgrT192306 Create MCR test wiki on WM Cloud
 ResolvedBstormT194239 Request creation of mcr-dev VPS project
 ResolvedCCicalese_WMFT196082 npm install for selenium tests not working on labs-vagrant
 ResolveddanielT194015 Make PageArchive aware of MCR
 ResolveddanielT194034 Make rollback inherit all slots from the target version
 ResolvedAddshoreT196585 Deploy some MCR related patches on test / group0 for an extended period
 ResolvedAnomieT198308 Enable MCR migration stage "write both, read new" on live systems
 ResolvedAnomieT198309 Enable MCR migration stage "write both, read new" on testwiki
 ResolvedtstarlingT183488 MCR schema migration stage 2: populate new fields
 ResolvedAnomieT183489 MCR schema migration stage 1: Fix Legacy Archive Rows
 ResolvedAnomieT183486 MCR schema migration stage 0: create tables
 ResolvedAnomieT36925 [MCR] create maintenance script for Migration of text from archive table to text table
 ResolvedAnomieT184629 Run maintenance/migrateArchiveText.php on all wikis
 ResolvedAnomieT191307 Run maintenance/populateArchiveRevId.php on all wikis
 ResolvedAnomieT193180 Clean up archive rows with duplicate revision IDs
 ResolvedAnomieT202032 Duplicate ar_rev_id values in several wikis
 ResolvedAnomieT174030 Implement DB schema migration tools for MCR
 ResolveddanielT174028 Finalize database schema for MCR content meta-data
ResolvedAnomieT182678 [MCR] Script for populating empty ar_rev_id fields
 ResolvedAnomieT182682 [MCR] Script(s) for populating new tables (slots, content, content_models, slot_roles)
 ResolvedMarosteguiT190153 DROP unused 'slots' table (WAS: In the slots table, replace slot_inherited with slot_origin)
 ResolvedAnomieT196172 Test schema migration script
 ResolvedtstarlingT197816 Enable MCR migration stage "write both, read old" on live systems
 ResolvedAnomieT197817 Enable MCR migration stage "write both, read old" on testwiki
 ResolveddanielT198561 Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI
 ResolvedAnomieT198563 Make "write both, read old" the default MCR migration stage on master / for CI
 ResolvedAnomieT198311 Enable MCR migration stage "write both, read new" on commons beta.
 ResolvedAnomieT197818 Enable MCR migration stage "write both, read old" on commons beta.
 ResolveddanielT197619 Introduce SCHEMA_COMPAT_XXX constants to allow more fine grained control over the migration process
 ResolveddanielT198413 Allow multiple slots to be used while still writing to the old as well as the new schema
 ResolveddanielT201164 Temporarily disable deprecation warnings for code that accesses rev_text_id or the text table directly
 ResolveddanielT205808 Ensure Revision::getRevisionText continues to function with MCR read-new mode
 ResolvedNoneT207308 Deploy MCR storage layer on Commons for SDC
 ResolvedNoneT207309 Enable MCR migration stage "write both, read new" on Commons for SDC

Event Timeline

Jdforrester-WMF changed the task status from Open to Stalled.Jan 10 2018, 3:56 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2018, 3:56 PM
Jdforrester-WMF added a subtask: T174043: Deploy Multi-Content Revisions.Jan 10 2018, 3:56 PM
Jdforrester-WMF added a parent task: T161671: Compacting the revision table.
Jdforrester-WMF mentioned this in T161671: Compacting the revision table.
kaldari updated the task description. (Show Details)Jan 10 2018, 7:38 PM
jcrespo moved this task from Triage to Blocked external/Not db team on the DBA board.Jan 10 2018, 7:41 PM
Nirmos added a subscriber: Nirmos.Apr 19 2018, 3:54 PM
daniel edited subtasks, added: T174044: Deploy MCR storage layer; removed: T174043: Deploy Multi-Content Revisions.May 15 2018, 11:48 AM
daniel removed a project: Epic.
CCicalese_WMF added projects: Platform Engineering (MCR), Platform Team Legacy (Later).Oct 3 2018, 7:15 PM
CCicalese_WMF moved this task from Inbox to Later on the Multi-Content-Revisions board.
CCicalese_WMF moved this task from Later to Tech Debt on the Multi-Content-Revisions board.Oct 4 2018, 3:01 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (Tech Debt); removed Multi-Content-Revisions.
Anomie mentioned this in T195515: GUC query performance regressed 100x from <3s to 80-300s.Oct 19 2018, 3:31 PM
Anomie mentioned this in T166733: Deploy refactored comment storage.Jan 8 2019, 3:22 PM
Kizule moved this task from Unsorted to Delete / Drop / Remove on the Schema-change board.Jan 25 2019, 7:30 PM
daniel added a subtask: T198341: Remove all references to the rev_text_id and ar_text_id fields.Feb 8 2019, 4:07 PM
daniel added a subtask: T198312: Set the WMF cluster to use the new MCR-only schema.
daniel mentioned this in T174044: Deploy MCR storage layer.Feb 8 2019, 4:10 PM
daniel closed subtask T174044: Deploy MCR storage layer as Resolved.
Anomie mentioned this in T198341: Remove all references to the rev_text_id and ar_text_id fields.Mar 13 2019, 5:35 PM
nshahquinn-wmf renamed this task from Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields to be dropped from revision to Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table.Mar 28 2019, 5:11 PM
WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 2:13 PM
WDoranWMF removed a project: Platform Team Legacy (Later).
Marostegui removed a project: DBA.Jul 8 2019, 4:51 AM
Marostegui added a subscriber: Marostegui.

I am going to remove the DBA tag from here as there is nothing for us to do yet.
Once this is ready to go, please follow the template to create a schema change request and we'll take care of it: https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change

WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:41 PM
WDoranWMF edited projects, added Platform Team Initiatives (MCR); removed Platform Engineering (MCR).
CCicalese_WMF edited projects, added Platform Team Initiatives (MCR Schema Migration); removed Platform Team Initiatives (MCR).Aug 1 2019, 3:31 AM
CCicalese_WMF edited projects, added Platform Team Initiatives (MCR); removed Platform Team Initiatives (MCR Schema Migration).Aug 27 2019, 1:05 PM
CCicalese_WMF removed a subtask: T198341: Remove all references to the rev_text_id and ar_text_id fields.Aug 30 2019, 10:51 PM
CCicalese_WMF removed a subtask: T198312: Set the WMF cluster to use the new MCR-only schema.Aug 30 2019, 11:48 PM
Anomie mentioned this in T215466: Remove revision_comment_temp and revision_actor_temp.Sep 17 2019, 5:48 PM
Anomie updated the task description. (Show Details)
JAllemandou added a subscriber: JAllemandou.Oct 22 2019, 7:56 PM

Adding Analytics as there is a high probability this change will impact how data is gathered onto the hadoop cluster.

JAllemandou added a project: Analytics.Oct 22 2019, 7:58 PM
Nuria added subscribers: Milimetric, Nuria.Oct 24 2019, 5:14 PM

ping @Milimetric

Nuria moved this task from Incoming to Radar on the Analytics board.Oct 24 2019, 5:16 PM
gerritbot added a comment.Nov 21 2019, 9:30 PM

Change 552339 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Alter revision for actor, comment, and MCR

https://gerrit.wikimedia.org/r/552339

gerritbot added a project: Patch-For-Review.Nov 21 2019, 9:30 PM
Anomie mentioned this in T238966: Apply updates for MCR, actor migration, and content migration, to production wikis..Nov 25 2019, 4:16 PM
Anomie mentioned this in T238958: Remove pre-MCR schema fields during update.
CCicalese_WMF closed this task as a duplicate of T238966: Apply updates for MCR, actor migration, and content migration, to production wikis..Nov 26 2019, 11:19 PM
gerritbot added a comment.May 8 2020, 3:43 PM

Change 552339 merged by jenkins-bot:
[mediawiki/core@master] Alter revision for actor, comment, and MCR

https://gerrit.wikimedia.org/r/552339

Maintenance_bot removed a project: Patch-For-Review.May 8 2020, 4:12 PM
Aklapper edited projects, added Analytics-Radar; removed Analytics.Jun 10 2020, 6:44 AM
Reedy mentioned this in T261059: drop_content_model_info.sql seems to be orphaned.Aug 23 2020, 1:04 AM
Izno removed a subtask: T238615: Adapt mediawiki history for MCR.Apr 27 2021, 5:36 PM
Izno mentioned this in T238615: Adapt mediawiki history for MCR.Apr 27 2021, 5:47 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL