Maniphest T194015

Make PageArchive aware of MCR
Closed, ResolvedPublic
Actions

Description

PageArchive is used to delete and undelete pages. It needs to become aware of the new MCR schema.

Details

Subject	Repo	Branch	Lines +/-
Fix undeletion write-both/read-old mode.	mediawiki/core	master	+171 -38
[MCR] Make PageArchive aware of MCR	mediawiki/core	master	+666 -335
Tests for preserving content ID and origin during undeletion	mediawiki/core	master	+72 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		daniel	T161671 Compacting the revision table
Duplicate		None	T184615 Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Resolved		daniel	T174044 Deploy MCR storage layer
Resolved		daniel	T174023 Implement MCR storage layer
Resolved		daniel	T194015 Make PageArchive aware of MCR

Event Timeline

daniel triaged this task as Medium priority.May 7 2018, 10:15 AM

daniel created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2018, 10:15 AM

Change 426009 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [MCR] Make PageArchive aware of MCR

https://gerrit.wikimedia.org/r/426009

gerritbot added a project: Patch-For-Review.May 7 2018, 10:16 AM

daniel moved this task from Inbox to Done on the Multi-Content-Revisions board.May 7 2018, 10:39 AM

Change 425287 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Tests for preserving content ID and origin during undeletion

https://gerrit.wikimedia.org/r/425287

CCicalese_WMF moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.May 8 2018, 12:21 AM

CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 8 2018, 12:56 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.

CCicalese_WMF moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 8 2018, 1:03 PM

CCicalese_WMF moved this task from In Progress to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 31 2018, 5:19 PM

CCicalese_WMF added a subtask: T196653: Test MCR Storage Layer Patches.Jun 7 2018, 4:46 PM

CCicalese_WMF removed a subtask: T196653: Test MCR Storage Layer Patches.Jun 7 2018, 5:30 PM

Change 425287 merged by jenkins-bot:
[mediawiki/core@master] Tests for preserving content ID and origin during undeletion

https://gerrit.wikimedia.org/r/425287

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 14 2018, 4:00 PM

Ladsgroup moved this task from incoming to blocked on others on the Wikidata board.Jun 28 2018, 3:36 PM

Ladsgroup moved this task from blocked on others to monitoring on the Wikidata board.

• Vvjjkkii renamed this task from Make PageArchive aware of MCR to 0hdaaaaaaa.Jul 1 2018, 1:11 AM

• Vvjjkkii removed daniel as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from 0hdaaaaaaa to Make PageArchive aware of MCR.Jul 2 2018, 1:56 PM

CommunityTechBot assigned this task to daniel.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

Change 426009 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Make PageArchive aware of MCR

https://gerrit.wikimedia.org/r/426009

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jul 11 2018, 12:01 AM

CCicalese_WMF edited projects, added Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018); removed MediaWiki-Platform-Team-Archived.Jul 11 2018, 11:35 PM

CCicalese_WMF moved this task from Backlog to In Progress on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.

daniel closed this task as Resolved.Jul 13 2018, 8:41 AM

CCicalese_WMF moved this task from Blocked on Review to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jul 13 2018, 11:40 AM

CCicalese_WMF moved this task from In Progress to Closed on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Jul 13 2018, 9:44 PM

A test for Cognate fails due to https://gerrit.wikimedia.org/r/426009 : T200072

I have no idea whether that is an issue with the PageArchive being made aware of MCR or if it is an issue in Cognate itself.

Lets follow up on T200072

Change 455630 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix undeletion write-both/read-old mode.

https://gerrit.wikimedia.org/r/455630

Change 455630 merged by jenkins-bot:
[mediawiki/core@master] Fix undeletion write-both/read-old mode.

https://gerrit.wikimedia.org/r/455630

DannyS712 mentioned this in T249982: PageArchive::getRevision uses timestamp, suggested replacement uses rev id.Apr 11 2020, 7:40 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 11 2020, 8:23 AM