Page MenuHomePhabricator
Create Task
Maniphest T194034

Make rollback inherit all slots from the target version
Closed, ResolvedPublic
Actions

Description

WikiPage::doRollback needs to consider all slots. Also, when performing a rollback, the slot content should be inherited from the revision that created them.

Details

SubjectRepoBranchLines +/-
[MCR] Rollback for all slotsmediawiki/coremaster+85 -49
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenBUG REPORTNoneT12863 Links on commons upload summaries do not link to commons
 OpenNoneT5498 Image history is confusing
 StalledNoneT96384 Integrate file revisions with description page history
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 OpenNoneT122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
 OpenNoneT135221 Make TimedText content an integral part of the File page
 OpenFeatureNoneT2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
 OpenNoneT132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenFeatureNoneT14963 allow per-page exceptions to spam blacklist
 OpenNoneT203157 Make the spam whitelist its own slot
 ResolveddanielT161671 Compacting the revision table
 DuplicateNoneT184615 Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table
 OpenFeatureNoneT56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
 StalledNoneT174043 Deploy Multi-Content Revisions
 OpenNoneT174022 Implement multi-content revisions
 ResolveddanielT174044 Deploy MCR storage layer
 ResolveddanielT174023 Implement MCR storage layer
 ResolveddanielT194034 Make rollback inherit all slots from the target version

Event Timeline

daniel triaged this task as Medium priority.May 7 2018, 12:27 PM
daniel created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2018, 12:27 PM
gerritbot subscribed.May 7 2018, 12:28 PM

Change 429421 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [WIP][MCR] Rollback for all slots

https://gerrit.wikimedia.org/r/429421

gerritbot added a project: Patch-For-Review.May 7 2018, 12:28 PM
daniel moved this task from Inbox to Done on the Multi-Content-Revisions board.May 7 2018, 12:28 PM
CCicalese_WMF moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.May 8 2018, 12:21 AM
CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 8 2018, 12:55 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 8 2018, 1:02 PM
CCicalese_WMF moved this task from In Progress to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 31 2018, 5:19 PM
daniel edited parent tasks, added: T174023: Implement MCR storage layer; removed: T174038: Initial implementation of MCR page update interface.Jun 15 2018, 11:35 AM
daniel moved this task from Blocked on Review to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 15 2018, 11:37 AM
daniel moved this task from In Progress to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 18 2018, 3:40 PM
gerritbot added a comment.Jun 23 2018, 3:16 PM

Change 429421 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Rollback for all slots

https://gerrit.wikimedia.org/r/429421

Tgr closed this task as Resolved.Jun 23 2018, 3:19 PM
• Petar.petkovic removed a project: Patch-For-Review.Jun 24 2018, 10:44 AM
• Petar.petkovic removed a subscriber: gerritbot.
CCicalese_WMF moved this task from Blocked on Review to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 26 2018, 4:25 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 3:01 PM
• Vvjjkkii renamed this task from Make rollback inherit all slots from the target version to hhdaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed daniel as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from hhdaaaaaaa to Make rollback inherit all slots from the target version.Jul 2 2018, 6:44 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to daniel.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
CCicalese_WMF removed a project: MediaWiki-Platform-Team-Archived.Jul 12 2018, 12:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits