Since today responsive references have stopped working. Only one column is shown on wide screens at the Czech Wikipedia at least.
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- rECITcd0c61e458be: Fix handling of `<references responsive="" />`
rECIT38d5bd5f394c: Add missing parser tests for relevant responsive edge cases
rECIT6f3fa70913f6: Fix handling of `<references responsive="" />` - Mentioned Here
- T101841: Value-less extension attributes not preserved
T33597: Render references list in multiple columns based on the number of items
Event Timeline
This comment was removed by Dvorapa.
Comment Actions
You are right, responsive=1 works, but responsive="" or responsive does not. But responsive="" is added by VisualEditor, when I check they should be responsive. This is weird.
Comment Actions
It seems that it depends on the article. Here is a short list of articles of the dewiki, where it works:
All articles use <references responsive />
Comment Actions
Nope. Cache cleared and page reloaded without cache access. Same result. Both in Firefox and Internet Explorer.
Comment Actions
Change 560850 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] Fix handling of <references responsive="" />
Comment Actions
Change 560927 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Add missing parser tests for relevant responsive edge cases
Comment Actions
Change 560850 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix handling of <references responsive="" />
Comment Actions
Not meant as a defense or anything, really just for documentation:
- When the responsive feature was implemented in 2015 via T33597 and https://gerrit.wikimedia.org/r/229852, it was untested. It would have been possible to add parser tests back then.
- It was still not covered by tests when we started working on the Cite extension as part of the ongoing Cite-Extends project. We noticed and added tests via https://gerrit.wikimedia.org/r/558541, but missed the edge case relevant for this issue.
- mw:Extension:Cite did not provided much information. Unfortunately we missed mw:Contributors/Projects/Columns for references.
- It felt wrong to let responsive="" enable the feature. We assumed this was a bug.
I confirmed that https://gerrit.wikimedia.org/r/560850 restores the old behavior. Unfortunately I haven't been able to create a backport. Can somebody help with this?
Comment Actions
What is not so nice in this regard is that if you manually put responsive="1" to be on the safe side then at least on de Wikipedia a bot TaxonBot comes and changes this back with reference to T101841. I now wonder what is the "correct" way of specifying this attribute if <references responsive /> was an edge case.
Comment Actions
<references responsive /> was and is correct. When I said "edge case" I meant <references responsive="" />, which is weird and should not be used. Anyway, both will be restored and will work as before.
Comment Actions
Change 560927 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Add missing parser tests for relevant responsive edge cases
Comment Actions
Change 561169 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@wmf/1.35.0-wmf.11] Fix handling of <references responsive="" />
Comment Actions
Change 561169 merged by jenkins-bot:
[mediawiki/extensions/Cite@wmf/1.35.0-wmf.11] Fix handling of <references responsive="" />
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2020-01-08T12:30:27Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.35.0-wmf.11/extensions/Cite: SWAT: [[gerrit:561169|Fix handling of <references responsive="" /> (T241303)]] (duration: 01m 06s)