Page MenuHomePhabricator

Special:LinkSearch listed in wrong section on Special:SpecialPages
Closed, ResolvedPublic

Description

https://abj.miraheze.org/wiki/Special:SpecialPages says

Redirecting special pages

• External links search

However nowadays it no longer redirects,

$ HEAD -SU https://abj.miraheze.org/wiki/Special:LinkSearch
HEAD https://abj.miraheze.org/wiki/Special:LinkSearch
User-Agent: lwp-request/6.43 libwww-perl/6.43

200 OK

Thus it is placed in the wrong section there on Special:SpecialPages.

Event Timeline

Jidanni created this task.Jan 7 2020, 6:42 PM
Restricted Application added a project: User-RhinosF1. · View Herald TranscriptJan 7 2020, 6:42 PM
Restricted Application added subscribers: RhinosF1, Aklapper. · View Herald Transcript
DannyS712 claimed this task.Jan 7 2020, 6:55 PM
DannyS712 added a subscriber: DannyS712.

Moving to pagetools

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 7 2020, 6:55 PM

Change 562580 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Move Special:LinkSearch to pagetools group

https://gerrit.wikimedia.org/r/562580

Change 562580 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Move Special:LinkSearch to pagetools group

https://gerrit.wikimedia.org/r/562580

+1

Moving to pagetools

LinkSearch was originally in redirects because of T16865: Search and Linksearch special pages belong in one group - to match Special:Search (done in r39138 by @siebrand, when it was still an extension).

In 505dbb331e1, Special:Search was moved into pages, because having it in redirects didn't make sense to @siebrand (It doesn't make sense to me either).

I agree with both of those rationales, and think that we should be moving Special:LinkSearch into pages to match Special:Search.

Moving to pagetools

LinkSearch was originally in redirects because of T16865: Search and Linksearch special pages belong in one group - to match Special:Search (done in r39138 by @siebrand, when it was still an extension).

In 505dbb331e1, Special:Search was moved into pages, because having it in redirects didn't make sense to @siebrand (It doesn't make sense to me either).

I agree with both of those rationales, and think that we should be moving Special:LinkSearch into pages to match Special:Search.

{{done}} in patch set 3

Sounds good

Change 562580 merged by jenkins-bot:
[mediawiki/core@master] Move Special:LinkSearch to pages group

https://gerrit.wikimedia.org/r/562580

This should be resolved with next train. Is it worth backporting?

This should be resolved with next train. Is it worth backporting?

Not warranted, though it could be mentioned in tech news