Make it harder to accidentally send unreview message to wrong person
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ammarpad
	Jan 9 2020, 9:09 AM

Description

In T233729, it was made possible to send a message to reviewer in addition the author of a page AND the new option ( sending to "reviewer") was made the default selection.

The order isn't ideal and have been causing confusion. Many messages are not going where they're supposed to go; see this self-message, this one too as well as this all of which were obviously meant for the "author" but ended up on the "reviewers" talkpage.

A more recent case is here on wiki where another reviewer is also confused.

The solution is simple, the order should be swapped. Sending to "author" should be the default selection

Details

	Subject	Repo	Branch	Lines +/-
	Send a message: Default to article creator	mediawiki/extensions/PageTriage	master	+2 -3
	Change unreview message default recipient to blank	mediawiki/extensions/PageTriage	master	+7 -2

Customize query in gerrit

Related Objects

Mentioned In: T319103: Tagging "mark as reviewed" checkbox default should match article state
Mentioned Here: T233729: Page Curation: Provide Customized Message to Previous Reviewer [small]

Event Timeline

Ammarpad created this task.Jan 9 2020, 9:09 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 9 2020, 9:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 563238 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Send a message: Default to article creator

https://gerrit.wikimedia.org/r/563238

gerritbot added a project: Patch-For-Review.Jan 9 2020, 6:28 PM

@Ammarpad sorry, didn't realize that you had assigned this to yourself. I've uploaded a patch that should fix this - can you take a look?

Barkeep49 subscribed.Jan 10 2020, 5:51 AM

No problem

DannyS712 claimed this task.Jan 11 2020, 8:45 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 11 2020, 8:45 AM

DannyS712 moved this task from Unsorted to Page Curation on the User-DannyS712 board.Jan 11 2020, 8:45 AM

Ammarpad unsubscribed.Jan 30 2020, 4:40 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 3 2022, 4:13 PM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

Novem_Linguae moved this task from Backlog to Soon on the PageTriage board.Jul 25 2022, 11:24 PM

I agree with the code reviewer that the algorithm in the existing patch is unusual. I might write a new patch that simply swaps the HTML <options> in modules/ext.pageTriage.views.toolbar/mark.underscore

<select id="mwe-pt-review-note-recipient">
	<option value="reviewer"><%- mw.msg( "pagetriage-add-a-note-for-option-reviewer", previousReviewer ) %></option>
	<option value="creator"><%- mw.msg( "pagetriage-add-a-note-for-option-creator", articleCreator ) %></option>
</select>

edit: I decided to take away the default completely. "Reviewer" seems like the most natural default to me. Switching it to "Creator" could just create the reverse problem. Having no default seems to me to be the safest option.

Novem_Linguae renamed this task from Page Curation: Swap the order of reviewer and author in message recipient menu to Make it harder to accidentally send unreview message to wrong person.Jul 25 2022, 11:43 PM

Change 816871 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Change unreview message default recipient to blank

https://gerrit.wikimedia.org/r/816871

gerritbot added a project: Patch-For-Review.Jul 25 2022, 11:51 PM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJul 25 2022, 11:51 PM

Novem_Linguae moved this task from Soon to Code Review on the PageTriage board.Jul 25 2022, 11:53 PM

Change 816871 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Change unreview message default recipient to blank

https://gerrit.wikimedia.org/r/816871

MPGuy2824 assigned this task to Novem_Linguae.Sep 26 2022, 7:33 AM

MPGuy2824 moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 26 2022, 8:00 AM

MPGuy2824 closed this task as Resolved.Sep 30 2022, 3:28 AM

MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.

Novem_Linguae mentioned this in T319103: Tagging "mark as reviewed" checkbox default should match article state.Oct 1 2022, 2:07 AM

Could a gerrit admin please mark https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/563238 as abandoned?

In T242324#8310059, @MPGuy2824 wrote:

Could a gerrit admin please mark https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/563238 as abandoned?

It's not the best etiquette to abandon someone else's patch, less so without asking them first — I've removed the "patch for review" tag from this task, but there's no harm in leaving the patch there for @DannyS712 to abandon :)

Change 563238 abandoned by Kosta Harlan:

[mediawiki/extensions/PageTriage@master] Send a message: Default to article creator

Reason:

Abandoning per latest comment.