Input field not cleared after selecting an entry
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Raymond
	Jan 9 2020, 10:16 AM

Description

The item input field is not cleared after selecting an entry for the 2nd, 3rd, etc. item.

Steps to reproduce:

Select a file with no SDC statement
Add the first depicted item. The input field is cleared for the next item
Add a 2nd item. After clicking on the selected item the input field is *not* cleared, see screenshot

I do not think that is a deployment blocker but at least a regression related to 1.35.0-wmf.14

QA Results

AC	Status	Details
1	✅	T242331#5830036
2	✅	T242331#5830036

Details

	Subject	Repo	Branch	Lines +/-
	Consolidate QualifierValueInputWidget & StatementInputWidget into MultiTypeInputWrapperWidget	mediawiki/extensions/WikibaseMediaInfo	master	+559 -599

Customize query in gerrit

Event Timeline

Raymond created this task.Jan 9 2020, 10:16 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 9 2020, 10:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Cparle added a project: Structured-Data-Backlog (Current Work).Jan 9 2020, 11:21 AM

matthiasmullie claimed this task.Jan 14 2020, 2:45 PM

matthiasmullie moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.

Change 564722 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Consolidate QualifierValueInputWidget & StatementInputWidget.js into MultiInputWidget

https://gerrit.wikimedia.org/r/564722

gerritbot added a project: Patch-For-Review.Jan 14 2020, 4:07 PM

matthiasmullie moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jan 14 2020, 4:09 PM

Change 564722 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Consolidate QualifierValueInputWidget & StatementInputWidget into MultiTypeInputWrapperWidget

https://gerrit.wikimedia.org/r/564722

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2020, 8:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 15 2020, 10:15 PM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 16 2020, 8:28 AM

This should also be testable on Beta Commons now :)

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

The item input field is not cleared after selecting an entry for the 2nd, 3rd, etc. item.

Steps to reproduce:

Select a file with no SDC statement
✅ AC1: Add the first depicted item. The input field is cleared for the next item
✅ AC2: Add a 2nd item. After clicking on the selected item the input field is cleared.

ezgif.com-optimize.gif (639×600 px, 1 MB)

Edtadros updated the task description. (Show Details)Jan 24 2020, 5:46 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Jan 27 2020, 4:41 PM

• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Feb 4 2020, 1:02 AM

The fix for this has been up on production for a while and appears to be working as intended

Input field not cleared after selecting an entryClosed, ResolvedPublicActions