Page MenuHomePhabricator

Remove $wgAllowRequiringEmailForResets feature flag [small]
Open, LowPublic

Description

As a PRU user, I want the feature flag removed from the codebase, so that the project can be complete & available to all users.

Background: We need to first do T245792, followed by T245791. When we have determined that PRU is stable, the $wgAllowRequiringEmailForResets feature flag should be removed.

Currently, DefaultSettings.php reads:

/**
 * Temporary feature flag that controls whether users will see a checkbox allowing them to
 * require providing email during password resets.
 *
 * @deprecated This feature is under development, don't assume this flag's existence or function
 *     outside of MediaWiki.
 */
$wgAllowRequiringEmailForResets = false;

Acceptance Criteria:

  • Remove feature flag from the codebase

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ifried renamed this task from Remove $wgAllowRequiringEmailForResets feature flag to Remove $wgAllowRequiringEmailForResets feature flag [small].Jan 16 2020, 7:13 PM
ifried moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.
ifried renamed this task from Remove $wgAllowRequiringEmailForResets feature flag [small] to Remove $wgAllowRequiringEmailForResets feature flag for Wikivoyage & Wiktionary [small].Feb 20 2020, 11:23 PM
ifried updated the task description. (Show Details)
ifried renamed this task from Remove $wgAllowRequiringEmailForResets feature flag for Wikivoyage & Wiktionary [small] to Remove $wgAllowRequiringEmailForResets feature flag [small].Feb 20 2020, 11:50 PM
ifried updated the task description. (Show Details)
ifried claimed this task.
ifried subscribed.

The project has been completed, so I'm closing the ticket.

Samwilson removed ifried as the assignee of this task.

The feature flag still needs to be removed.

Change 1004801 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/core@master] PasswordReset: remove $wgAllowRequiringEmailForResets feature flag

https://gerrit.wikimedia.org/r/1004801

MusikAnimal triaged this task as Low priority.EditedFeb 20 2024, 2:26 AM
MusikAnimal subscribed.

Removing the feature flag was easy. I struggled however to fix the tests. Presumably, the failing ones are testing scenarios where Password Reset Update does not apply. I recall when we worked on this, we provided different messaging with PWU enabled. I'll revisit when I have more time.