Page MenuHomePhabricator
Create Task
Maniphest T242677

CodeReview needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Description

See parent task

Codesearch: https://codesearch.wmcloud.org/deployed/?q=wgUser(%5B%3B%2C%27%22-%5D%7C%5Cs%7C%24)&i=nope&files=%5C.php%24&repos=mediawiki/extensions/CodeReview

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Jan 13 2020, 9:56 PM
DannyS712 triaged this task as Medium priority.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 13 2020, 9:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 13 2020, 9:57 PM

Change 564139 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/564139

gerritbot added a project: Patch-For-Review.Jan 13 2020, 9:57 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Jan 13 2020, 10:08 PM
gerritbot added a comment.Jan 15 2020, 5:24 PM

Change 565066 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/565066

gerritbot added a comment.Jan 15 2020, 5:48 PM

Change 564139 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/564139

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 15 2020, 6:00 PM
gerritbot added a comment.Jan 15 2020, 8:00 PM

Change 565066 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/565066

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2020, 8:11 PM
gerritbot added a comment.Jan 16 2020, 4:52 PM

Change 565348 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 3)

https://gerrit.wikimedia.org/r/565348

gerritbot added a project: Patch-For-Review.Jan 16 2020, 4:52 PM
gerritbot added a comment.Jan 16 2020, 8:30 PM

Change 565348 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 3)

https://gerrit.wikimedia.org/r/565348

gerritbot added a comment.Jan 16 2020, 8:37 PM

Change 565385 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser

https://gerrit.wikimedia.org/r/565385

gerritbot added a comment.Jan 16 2020, 9:02 PM

Change 565385 abandoned by DannyS712:
Remove use of global $wgUser (part 4)

Reason:
Too much to do at once, will split up

https://gerrit.wikimedia.org/r/565385

gerritbot added a comment.Jan 16 2020, 9:02 PM

Change 565385 restored by DannyS712:
Remove use of global $wgUser (part 4)

Reason:
One sec

https://gerrit.wikimedia.org/r/565385

gerritbot added a comment.Jan 16 2020, 9:03 PM

Change 565385 abandoned by DannyS712:
Remove use of global $wgUser (part 4, abandoned)

Reason:
Abandon

https://gerrit.wikimedia.org/r/565385

gerritbot added a comment.Jan 16 2020, 9:08 PM

Change 565388 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 4)

https://gerrit.wikimedia.org/r/565388

gerritbot added a comment.Jan 16 2020, 9:16 PM

Change 565390 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 5)

https://gerrit.wikimedia.org/r/565390

gerritbot added a comment.Jan 17 2020, 1:10 AM

Change 565423 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 6)

https://gerrit.wikimedia.org/r/565423

gerritbot added a comment.Jan 17 2020, 2:34 AM

Change 565388 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 4)

https://gerrit.wikimedia.org/r/565388

gerritbot added a comment.Jan 17 2020, 4:13 AM

Change 565390 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 5)

https://gerrit.wikimedia.org/r/565390

gerritbot added a comment.Jan 17 2020, 4:20 PM

Change 565423 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 6)

https://gerrit.wikimedia.org/r/565423

gerritbot added a comment.Jan 17 2020, 5:45 PM

Change 565647 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 7)

https://gerrit.wikimedia.org/r/565647

gerritbot added a comment.Jan 17 2020, 6:19 PM

Change 565663 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 8)

https://gerrit.wikimedia.org/r/565663

gerritbot added a comment.Jan 18 2020, 7:02 PM

Change 565647 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 7)

https://gerrit.wikimedia.org/r/565647

gerritbot added a comment.Jan 18 2020, 7:02 PM

Change 565663 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 8)

https://gerrit.wikimedia.org/r/565663

gerritbot added a comment.Jan 18 2020, 8:47 PM

Change 565747 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 9)

https://gerrit.wikimedia.org/r/565747

gerritbot added a comment.Jan 19 2020, 4:52 PM

Change 565747 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 9)

https://gerrit.wikimedia.org/r/565747

DannyS712 added a comment.Jan 20 2020, 5:48 PM

Remaining uses:

  • CodeRepoListView::execute
  • CodeRevisionAuthorView::execute
  • CodeRevisionListView::execute

A lot of the views are constructed in SpecialCode::getViewFrom, and I think a user parameter should be added to the constructors when needed

DannyS712 mentioned this in T243337: Argument 3 passed to CodeRevisionView::__construct() must be an instance of User, string given, called in /srv/mediawiki/php-1.35.0-wmf.16/extensions/CodeReview/includes/ui/SpecialCode.php on line 134.Jan 21 2020, 9:04 PM
gerritbot added a comment.Jan 21 2020, 9:06 PM

Change 566360 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Follow-Up 81f5fb: Remove use of global $wgUser (part 10)

https://gerrit.wikimedia.org/r/566360

gerritbot added a comment.Jan 21 2020, 11:57 PM

Change 566360 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Follow-Up 81f5fb: Remove use of global $wgUser (part 10)

https://gerrit.wikimedia.org/r/566360

gerritbot added a comment.Jan 21 2020, 11:59 PM

Change 566385 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@wmf/1.35.0-wmf.16] Follow-Up 81f5fb: Remove use of global $wgUser (part 10)

https://gerrit.wikimedia.org/r/566385

gerritbot added a comment.Jan 22 2020, 9:39 PM

Change 566385 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@wmf/1.35.0-wmf.16] Follow-Up 81f5fb: Remove use of global $wgUser (part 10)

https://gerrit.wikimedia.org/r/566385

DannyS712 added a subscriber: Catrope.Jan 22 2020, 9:40 PM

@Catrope can you sync with production so that the change takes affect?

gerritbot added a comment.Jan 23 2020, 7:19 AM

Change 566654 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 11)

https://gerrit.wikimedia.org/r/566654

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Jan 23 2020, 7:20 AM

Part 11 is the last one

gerritbot added a comment.Jan 23 2020, 7:43 PM

Change 566654 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of global $wgUser (part 11)

https://gerrit.wikimedia.org/r/566654

DannyS712 closed this task as Resolved.Jan 23 2020, 7:44 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 6 2020, 8:49 PM
DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM
DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.
DannyS712 reopened this task as Open.Sep 11 2020, 7:01 PM
DannyS712 removed DannyS712 as the assignee of this task.
DannyS712 moved this task from Resolved (deprecation) to In progress on the User-DannyS712 board.

Missed one in includes/backend/CodeRevision.php

DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Sep 11 2020, 7:13 PM
DannyS712 updated the task description. (Show Details)Sep 11 2020, 7:21 PM
gerritbot added a comment.Sep 13 2020, 7:48 PM

Change 626889 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove use of $wgUser in emailNotifyUsersOfChanges

https://gerrit.wikimedia.org/r/626889

gerritbot added a project: Patch-For-Review.Sep 13 2020, 7:48 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Sep 13 2020, 7:50 PM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).
gerritbot added a comment.Sep 14 2020, 4:46 AM

Change 626889 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove use of $wgUser in emailNotifyUsersOfChanges

https://gerrit.wikimedia.org/r/626889

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 14 2020, 5:00 AM
DannyS712 closed this task as Resolved.Sep 14 2020, 5:03 AM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits