Regression: Watchstar CTA fails to display properly 2nd and 3rd time
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 14 2020, 7:27 PM

Description

ezgif-6-8d9d4130e96d.gif (459×600 px, 838 KB)

QA steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain incognito
Click watchstar
A drawer displays. Note the translucent shield. Close it using the arrow at the top.
Click watchstar again. A drawer displays again with the shield.
Click watchstar a 3rd time. A drawer displays again with the shield.

QA Results

AC	Status	Details
1	✅	T242784#5819567
2	✅	T242784#5819567
3	✅	T242784#5819567

Details

	Subject	Repo	Branch	Lines +/-
	Add shield transparent class in show not postRender	mediawiki/extensions/MobileFrontend	master	+9 -4

Customize query in gerrit

Related Objects

Mentioned In: T360889: Drawer overlay mask doesn't transition
T214049: Technical: Every Drawer has a shield for catching clicks
T214647: [EPIC] Re-define the contract for displaying drawers and overlays in MobileFrontend

Event Timeline

Jdlrobson created this task.Jan 14 2020, 7:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2020, 7:27 PM

Jdlrobson updated the task description. (Show Details)Jan 14 2020, 7:27 PM

Change 564151 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Add shield transparent class in show not postRender

https://gerrit.wikimedia.org/r/564151

gerritbot added a project: Patch-For-Review.Jan 14 2020, 7:31 PM

Jdlrobson mentioned this in T214647: [EPIC] Re-define the contract for displaying drawers and overlays in MobileFrontend.Jan 14 2020, 7:33 PM

ovasileva triaged this task as Medium priority.Jan 14 2020, 7:33 PM

Jdlrobson mentioned this in T214049: Technical: Every Drawer has a shield for catching clicks.Jan 14 2020, 7:40 PM

Change 564151 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add shield transparent class in show not postRender

https://gerrit.wikimedia.org/r/564151

Jdlrobson moved this task from Upcoming to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 14 2020, 9:17 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 14 2020, 10:00 PM

• Niedzielski added a project: MobileFrontend.Jan 15 2020, 3:47 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2020, 4:11 PM

Jdlrobson assigned this task to Edtadros.Jan 20 2020, 6:08 PM

Jdlrobson updated the task description. (Show Details)

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain incognito
Click watchstar
✅ AC1: A drawer displays. Note the translucent shield. Close it using the arrow at the top.
✅ AC2: Click watchstar again. A drawer displays again with the shield.
✅ AC3: Click watchstar a 3rd time. A drawer displays again with the shield.