Page MenuHomePhabricator

Drawer overlay mask doesn't transition
Open, LowPublic

Description

The overlay mask shown when a drawers are shown is supposed to transition in (it has transition: opacity... set), but doesn't.

This can be verified by slowing down animations in the Chrome debugger.

Event Timeline

Change #1014012 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Fix drawer mask transitions

https://gerrit.wikimedia.org/r/1014012

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e443cf90ce/w

The code that probably caused the regression was introduced to fix T242784. I've verified the above doesn't cause an regression with that issue:

https://patchdemo.wmflabs.org/wikis/e443cf90ce/w/index.php?title=Douglas_Adams&mobileaction=toggle_view_mobile

Jdlrobson subscribed.

Adding to sprint 2 for consideration as there is a patch open from Ed.