Page MenuHomePhabricator
Create Task
Maniphest T360889

Drawer overlay mask doesn't transition
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The overlay mask shown when a drawers are shown is supposed to transition in (it has transition: opacity... set), but doesn't.

This can be verified by slowing down animations in the Chrome debugger.

QA Results - Beta

ACStatusDetails
1✅T360889#10004396

Details

SubjectRepoBranchLines +/-
Fix drawer mask transitionsmediawiki/extensions/MobileFrontendmaster+32 -35
Customize query in gerrit

Related Objects

Event Timeline

• Esanders created this task.Mar 25 2024, 12:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2024, 12:35 PM
• Esanders added a project: Regression.Mar 25 2024, 2:03 PM
gerritbot added a comment.Mar 25 2024, 2:03 PM

Change #1014012 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Fix drawer mask transitions

https://gerrit.wikimedia.org/r/1014012

gerritbot added a project: Patch-For-Review.Mar 25 2024, 2:03 PM
PatchDemoBot added a comment.Mar 25 2024, 2:10 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e443cf90ce/w

• Esanders added a comment.Mar 25 2024, 2:19 PM

The code that probably caused the regression was introduced to fix T242784. I've verified the above doesn't cause an regression with that issue:

https://patchdemo.wmflabs.org/wikis/e443cf90ce/w/index.php?title=Douglas_Adams&mobileaction=toggle_view_mobile

KSarabia-WMF added a project: Web-Team-Backlog.Mar 27 2024, 11:31 PM
Jdlrobson assigned this task to • Esanders.Apr 15 2024, 3:08 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 2); removed Web-Team-Backlog.
Jdlrobson subscribed.

Adding to sprint 2 for consideration as there is a patch open from Ed.

SToyofuku-WMF triaged this task as Low priority.Apr 18 2024, 5:52 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (FY2023-24 Q4 Sprint 2).Apr 23 2024, 5:25 PM
Jdrewniak moved this task from Incoming to FY2023-24 Q4 Sprint 4 on the Web-Team-Backlog board.May 21 2024, 3:13 PM
Jdrewniak edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 4); removed Web-Team-Backlog.
Jdlrobson set the point value for this task to 2.May 21 2024, 4:17 PM
Jdlrobson moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 24 2024, 9:41 PM
Jdlrobson moved this task from Ready for Development to Needs analysis on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 28 2024, 4:38 PM
Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 4) board.May 28 2024, 5:22 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 5); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 4).May 29 2024, 10:57 PM
Jdlrobson moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.
Jdlrobson moved this task from Ready for Development to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.May 30 2024, 6:08 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q4 Sprint 6); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 5).Jun 10 2024, 5:47 PM
Jdlrobson moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Jun 12 2024, 6:00 PM
ovasileva moved this task from Ready for Development to Ready for estimation on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Jun 13 2024, 9:41 AM
ovasileva edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 6).Jun 18 2024, 10:56 AM
ovasileva moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.Jun 20 2024, 10:57 AM
gerritbot added a comment.Tue, Jul 9, 3:00 PM

Change #1014012 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix drawer mask transitions

https://gerrit.wikimedia.org/r/1014012

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Tue, Jul 9, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Jul 9, 3:47 PM
Jdlrobson reassigned this task from • Esanders to GMikesell-WMF.Tue, Jul 9, 5:48 PM
Jdlrobson moved this task from Ready for Development to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.
Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 2); removed Web-Team-Backlog (FY2024-25 Q1 Sprint 1).Mon, Jul 15, 5:59 PM
Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 2) board.
GMikesell-WMF mentioned this in T370084: Verify 1.43.0-wmf.14 deployment.Tue, Jul 16, 11:42 PM
GMikesell-WMF added a comment.EditedFri, Jul 19, 1:00 AM

@Jdlrobson Can you please review my gif? What exactly am I looking for to complete this test?

Test Result - Beta

Status: ❓NMI
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Go to Developer Tools
  2. Click on the 3 dots on the right which is between the setting gear and "X"
  3. Hover on More tools
  4. Click on Animations
  5. Switch percentage from 100% to 10%
  6. Click on citation "1" to bring up the Drawer.

This can be verified by slowing down animations in the Chrome debugger.

GifScreenshot
2024-07-22_08-30-39.mp4.gif (874×1 px, 2 MB)
2024-07-22_08-33-14.png (1×3 px, 541 KB)
GMikesell-WMF updated the task description. (Show Details)Fri, Jul 19, 1:00 AM
Jdlrobson reassigned this task from GMikesell-WMF to Jdrewniak.Fri, Jul 19, 4:10 PM
Jdlrobson added a subscriber: GMikesell-WMF.

Can you provide some QA steps on this one? Thanks in advance!

GMikesell-WMF added a comment.Mon, Jul 22, 3:35 PM

@Jdlrobson please see the updated steps with gif on the whole process and a screenshot on T360889#9997415

Jdrewniak added a comment.Mon, Jul 22, 7:09 PM

@GMikesell-WMF the gif you provided (attached below with size=full to show animation) actually demonstrates the transition with opacity successfully (the reference toast fades in). Looks like a pass to me 👍

2024-07-22_08-30-39.mp4.gif (874×1 px, 2 MB)

GMikesell-WMF updated the task description. (Show Details)Mon, Jul 22, 7:25 PM
GMikesell-WMF removed Jdrewniak as the assignee of this task.Tue, Jul 23, 5:22 PM
GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 2) board.
GMikesell-WMF added a subscriber: Jdrewniak.
Jdlrobson closed this task as Resolved.Fri, Jul 26, 3:58 PM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits