Page MenuHomePhabricator

Make MobileFrontend and MinervaNeue compatible with BookReferencing
Open, Needs TriagePublic5 Estimated Story Points

Description

The idea is to show the parent along with the sub-reference, so the user can understand the structure. This is the same issue and proposed solution as T239228: Make the ReferencePreviews feature of Popups compatible with BookReferencing for the Reference Previews feature.

Here's an example screenshot of a test page with an opened preview popup for a subreference:

Things to be done

  • Identify sub-references when scraping the preview text from the wiki page
  • Identify the parent reference
  • Scrape content of the parent reference
  • Combine both in the preview (TBD by design) see also T239228

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJan 15 2020, 6:45 PM
awight updated the task description. (Show Details)Jan 21 2020, 11:42 AM
Tobi_WMDE_SW set the point value for this task to 8.
Tobi_WMDE_SW added a subscriber: Tobi_WMDE_SW.

We'll work on points 1-3 and wait for design feedback for point 4.

Tobi_WMDE_SW changed the point value for this task from 8 to 5.Jan 21 2020, 2:08 PM

For implementing this, please also see how it's done in the patch for the same issue with Reference Previews in https://gerrit.wikimedia.org/r/566710/

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-01-21 board.

Change 567458 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/MobileFrontend@master] [WIP] Include parent text on extended references

https://gerrit.wikimedia.org/r/567458

Here is the screenshot of the prototype design with a sub reference (It's not reviewed with Hanna, sharing as a follow up to our daily.)

Change 570090 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/MobileFrontend@master] Fix ReferencesHtmlScraperGateway showing child references

https://gerrit.wikimedia.org/r/570090

I'm seeing a UI regression with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/570090/ on [[:en:Yeomanry_Cavalry]]


note the lack of space after [3]

Jdlrobson added subscribers: alexhollender, ovasileva.

Adding to our kanbanan for visibility since proposed changes impact Minerva look and feel (cc @ovasileva and @alexhollender)

Adding to our kanbanan for visibility since proposed changes impact Minerva look and feel (cc @ovasileva and @alexhollender)

Is this for code review or product & design review for the changes proposed?

I just want to give @alexhollender the chance to see the mock on T242899#5836008 before taking care of the code review of the changes proposed.

We've iterated the prototype in the latest UX Meeting so this is up to date:

Noting that our board is a bit full at the moment, but we will be reviewing this once @alexhollender has some time

I've been in communication with @Erdinc_Ciftci_WMDE — the proposed design for mobile looks good. Removing this from our board.

Change 570090 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix ReferencesHtmlScraperGateway showing child references

https://gerrit.wikimedia.org/r/570090