Page MenuHomePhabricator
Create Task
Maniphest T243785

Expand single errors by default
Closed, ResolvedPublic
Actions

Description

If the list of errors inside ErrorPermission contains only one element, this element is supposed to be shown as expanded by default.

Details

SubjectRepoBranchLines +/-
bridge: expand single errors by defaultmediawiki/extensions/Wikibasemaster+231 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE created this task.Jan 27 2020, 4:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2020, 4:56 PM
Lucas_Werkmeister_WMDE claimed this task.Jan 27 2020, 5:04 PM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-12 board.
gerritbot added a comment.Jan 27 2020, 5:17 PM

Change 567486 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: expand single errors by default

https://gerrit.wikimedia.org/r/567486

gerritbot added a project: Patch-For-Review.Jan 27 2020, 5:17 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-12 board.Jan 27 2020, 5:19 PM
• Pablo-WMDE added a project: Wikidata-Bridge-Sprint-13.Jan 28 2020, 12:18 PM
• Pablo-WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-13 board.
gerritbot added a comment.Jan 28 2020, 2:59 PM

Change 567486 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: expand single errors by default

https://gerrit.wikimedia.org/r/567486

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 28 2020, 3:01 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-12 board.Jan 28 2020, 3:04 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.
Lucas_Werkmeister_WMDE added a subscriber: Charlie_WMDE.

@Charlie_WMDE can you try it out? (Let me know if you need me to block you again^^)

Charlie_WMDE added a comment.Jan 28 2020, 3:06 PM

@Lucas_Werkmeister_WMDE i need you to block me again :)

Lucas_Werkmeister_WMDE added a comment.Jan 28 2020, 3:07 PM

done :)

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2020, 3:10 PM
Charlie_WMDE added a comment.EditedJan 28 2020, 3:11 PM

it's still collapsed for me by default :(

i tested here https://de.wikipedia.beta.wmflabs.org/wiki/Data-Bridge

if that's the wrong place to test, let me know

Lucas_Werkmeister_WMDE added a comment.Jan 28 2020, 3:28 PM

Hm, maybe the code hadn’t updated yet? Can you try again? It should be deployed now.

Charlie_WMDE added a comment.Jan 29 2020, 12:36 PM

@Lucas_Werkmeister_WMDE i was gone yesterday already. can you block me again so i can test?

Charlie_WMDE closed this task as Resolved.Jan 29 2020, 1:25 PM
Charlie_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-13 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits