Discussed with @Charlie_WMDE during task break-down (N° 10):

• error reasons for client and repo will be shown in the interface alongside
  • client reason(s) will be clustered first
  • repo reason(s) will be clustered second

We did not commit to this during the sprint start of Wikidata-Bridge-Sprint-11 as we expect some conflict and/or synergies with T235154: show error when editor can't edit the statement because of permission errors on the repository which are hard to parallelize but under-comitted a little in the hope to address at least parts of this during this sprint.

i just tested this. I noticed a few things:

• the expandable element was collapsed when i opened it. It should be expanded by default.
• the main message should be 8px away from the expand text and the text in the collapsible element should be 16px away from the expand text
• there should be 4px between the expand icon and the expand text
• between "what can i do" and it's body should be 8px
• the distance to the next text above and below the two bullet points should be 8px. it's currently 7px.

I linked the right place in the figma document for the exact specs on everything

Change 567089 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: refactor ErrorPermissionInfo

https://gerrit.wikimedia.org/r/567089

Change 567876 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] ErrorPermission: fix content spacing

https://gerrit.wikimedia.org/r/567876

Change 567089 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: refactor ErrorPermissionInfo

https://gerrit.wikimedia.org/r/567089

Change 567876 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ErrorPermission: fix content spacing

https://gerrit.wikimedia.org/r/567876

This still happens in my browser (firefox)

Okay, so that’s just the translator’s fault, they used * syntax instead of <li> syntax despite the message documentation advising that it doesn’t work 😖

But also –

Die Sperrung wurde vom Administrator Charlie Kritschmar (WMDE) durchgeführt.

Charlie isn’t an Administrator, she’s an Administratorin. But currently we don’t support correct gendering in that message – we only pass in a DOM element with the user name, not anything that could be passed into {{GENDER}}.

I’ve fixed the German translation, as far as I can tell no other translation made the same mistake.

we only pass in a DOM element with the user name, not anything that could be passed into {{GENDER}}.

It turns out that gender in jqueryMsg works differently anyways. You don’t pass in any user name, you pass in the gender directly – "male", "female", "unknown". (That’s all MediaWiki recognizes, sadly.)

But that means we need to make another API call – something like https://de.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=users&usprop=gender&ususerids=689 – to get something we can pass into the message. (Probably as a new $10 parameter.) And I don’t think we can batch this with anything.

In T237507#5845332, @Lucas_Werkmeister_WMDE wrote:

we only pass in a DOM element with the user name, not anything that could be passed into {{GENDER}}.

It turns out that gender in jqueryMsg works differently anyways. You don’t pass in any user name, you pass in the gender directly – "male", "female", "unknown". (That’s all MediaWiki recognizes, sadly.)

But that means we need to make another API call – something like https://de.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=users&usprop=gender&ususerids=689 – to get something we can pass into the message. (Probably as a new $10 parameter.) And I don’t think we can batch this with anything.

@Lucas_Werkmeister_WMDE do you want to make an extra ticket for this? since this was not part of the initial AC

currently looks like this in my browser (firefox)

also i realised, the header is off to the side instead of centered. or rather it is centered between the edge of the header and the right edge of the close button, but the centering should be done looking at the edges of the header only, not the buttons. i know there's aticket to fix this for step 2 i believe but this just looks really bad. maybe there's a way to fix this at least for the cases where we have no "publish" button? we have a lt of them and this really looks no bueno @Lydia_Pintscher

currently looks like this in my browser (firefox)

I made a typo in the markup, sorry. Somebody else already fixed it, so it should resolve itself tomorrow.

@Lucas_Werkmeister_WMDE do you want to make an extra ticket for this? since this was not part of the initial AC

I also realized two things:

• The MediaWiki core message doesn’t have anything GENDER-able either.
• There is no reason for the German translation to use the gendered word „Administrator“. The English original (of both MediaWiki core and Wikidata Bridge) doesn’t say “The block was made by the administrator $1”, only “The block was made by $1”.

So I’ve just updated the message to remove the word „Administrator“ (both for MediaWiki core and Wikidata Bridge), and I think we can leave it at that.

In T237507#5848435, @Lucas_Werkmeister_WMDE wrote:

@Lucas_Werkmeister_WMDE do you want to make an extra ticket for this? since this was not part of the initial AC

I also realized two things:

• The MediaWiki core message doesn’t have anything GENDER-able either.
• There is no reason for the German translation to use the gendered word „Administrator“. The English original (of both MediaWiki core and Wikidata Bridge) doesn’t say “The block was made by the administrator $1”, only “The block was made by $1”.

So I’ve just updated the message to remove the word „Administrator“ (both for MediaWiki core and Wikidata Bridge), and I think we can leave it at that.

sounds good to me!