Page MenuHomePhabricator
Create Task
Maniphest T245500

{{GENDER}} support for Logentry-growthexperiments-setmentor and Logentry-growthexperiments-setmentor-no-previous-mentor
Closed, ResolvedPublic
Actions

Description

Hi,

The messages Logentry-growthexperiments-setmentor and Logentry-growthexperiments-setmentor-no-previous-mentor seem to have incomplete GENDER support.

Their qqq currently says:

  • $1 - user who performed the action (usually linked to the user page)
  • $2 - unused, or user who performed the action (to be used with GENDER)
  • $3 - the affected page (usually linked)

From the qqq it looks like it only has GENDER support for the user who performed the action. It also needs GENDER support for the new mentor, the previous mentor, and the mentee.

Logentry-growthexperiments-setmentor appears to have support for the GENDER of the previous mentor, but it's not documented in qqq.

Details

SubjectRepoBranchLines +/-
Use custom LogFormatter for mentor changesmediawiki/extensions/GrowthExperimentsmaster+77 -14
Slight rephrasing of mentor log entriesmediawiki/extensions/GrowthExperimentsmaster+2 -2
Customize query in gerrit

Event Timeline

Amire80 created this task.Feb 18 2020, 12:15 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptFeb 18 2020, 12:15 PM
Amire80 moved this task from Untriaged to Gender on the I18n board.Feb 18 2020, 12:15 PM
Aklapper added a project: Gender-Support.Feb 18 2020, 2:03 PM
Urbanecm subscribed.Feb 18 2020, 4:33 PM

This is a docs issue. I'll update the qqq.

Urbanecm claimed this task.Feb 18 2020, 5:10 PM

Done. Could you please review and give your feedback?

1, 2

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptFeb 18 2020, 5:10 PM
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Feb 18 2020, 5:11 PM
gerritbot added a comment.Feb 19 2020, 5:02 PM

Change 573334 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/GrowthExperiments@master] Slight rephrasing of mentor log entries

https://gerrit.wikimedia.org/r/573334

gerritbot added a project: Patch-For-Review.Feb 19 2020, 5:02 PM
Amire80 added a comment.Feb 19 2020, 5:03 PM

Thanks. I added a few trivial improvements to the messages themselves.

As far as I can see, this still doesn't have GENDER support for the mentee. Or am I missing something?

gerritbot added a comment.Feb 19 2020, 7:24 PM

Change 573334 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Slight rephrasing of mentor log entries

https://gerrit.wikimedia.org/r/573334

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 19 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 8:10 PM
Urbanecm added a comment.Jun 8 2020, 10:32 PM
In T245500#5897888, @Amire80 wrote:

Thanks. I added a few trivial improvements to the messages themselves.

As far as I can see, this still doesn't have GENDER support for the mentee. Or am I missing something?

Sorry, where would you expect GENDER? I don't see anything missing, but you're the lang expert here ;).

IvaBerlin subscribed.Jun 9 2020, 7:22 AM

Sorry to break in on this. I am active mainly in the German Wikipedia. There are also mentors and mentees.

For a long time already I find it disturbing that I can only refer new Wikipedians to the gender-insensitive platform for mentors. I know the module where it is marked that someone is active as a mentor. There is also a building block for mentees. Is everything there really gender-fair?

Doubting greetings Iva

Aklapper added a comment.EditedJun 9 2020, 7:38 AM

@IvaBerlin: Hi and welcome to Wikimedia Phabricator! Could you please elaborate what exactly is a "gender-insensitive platform for mentors" and how that is related to the two strings Logentry-growthexperiments-setmentor and Logentry-growthexperiments-setmentor-no-previous-mentor? Links are also welcome. Thanks!

IvaBerlin added a comment.Jun 9 2020, 8:07 AM

I don't know enough about strings. However, I have made the experience that many of the gender-sensitive determinations in wiki projects depend on gender-sensitive selection being considered at a very early stage. Currently, many definitions are still happening without this consideration. If a Wikipedian is female, this is seen as the exception. So it seems "normal" that in Wikipedia a mentor is male. And a pre-mentor as well. The same applies to mentees.

If I misunderstood something, I apologize. In the German language we have more often than in the English language a so-called generic masculinum. And it is often argued that a change must first be made in the Phabricator. That's why I dared to intervene.

Is it answered now?

Aklapper added a comment.Jun 9 2020, 8:26 AM

@IvaBerlin: This seems not to be related to the two specific messages/strings that this task is about? If you run into specific messages which cannot be properly translated to your language and to your language's genders, then please file specific bug reports in Phabricator so someone can repair them - thank you!

IvaBerlin added a comment.Jun 9 2020, 10:09 AM

ok. I thank you for your inquiry and your solution. :)

gerritbot added a comment.Jul 4 2020, 9:52 AM

Change 609528 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/GrowthExperiments@master] Use LogFormatter for mentor changes

https://gerrit.wikimedia.org/r/609528

gerritbot added a project: Patch-For-Review.Jul 4 2020, 9:52 AM
matej_suchanek claimed this task.Jul 4 2020, 9:53 AM
Urbanecm added a project: Growth-Team (Sprint 0 (Growth Team)).Jul 6 2020, 3:06 PM
Urbanecm moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 6 2020, 8:39 PM
gerritbot added a comment.Jul 6 2020, 8:48 PM

Change 609528 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Use custom LogFormatter for mentor changes

https://gerrit.wikimedia.org/r/609528

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Jul 6 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 6 2020, 9:10 PM
Etonkovidova closed this task as Resolved.Jul 8 2020, 10:01 PM
Etonkovidova subscribed.

Logentry-growthexperiments-setmentor appears to have support for the GENDER of the previous mentor, but it's not documented in qqq.

It was corrected on MediaWiki:Logentry-growthexperiments-setmentor-no-previous-mentor/qqq
$4 - name of the previous mentor, for use in GENDER

$1 {{GENDER:$2|set}} {{GENDER:$5|$7}} as the mentor of {{GENDER:$6|$3}} (previous {{GENDER:$4|mentor}} $8)

MediaWiki:Logentry-growthexperiments-setmentor-no-previous-mentor/qqq
$1 {{GENDER:$2|set}} {{GENDER:$5|$7}} as the mentor of {{GENDER:$6|$3}} (no previous mentor)

Urbanecm edited subscribers, added: Urbanecm_WMF; removed: Urbanecm.Aug 26 2020, 1:51 PM
Urbanecm edited projects, added User-Urbanecm_WMF; removed User-Urbanecm.Oct 23 2020, 5:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits