Maniphest T246369

JobRunner - clean up deprecations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Feb 27 2020, 6:26 PM

Tags

Referenced Files

None

Subscribers

Description

As a part of the parent task the following JobRunner features has been deprecated:

No-argument constructor.
JobRunner::setLogger and the fact JobRunner implements LoggerAwareInterface.

These should be cleaned up in 1.36

Details

	Subject	Repo	Branch	Lines +/-
	jobqueue: Remove JobRunner::setLogger and make constructor internal	mediawiki/core	master	+25 -44

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Pchelolo	T157088 [EPIC] Develop a JobQueue backend based on EventBus
		Open		None	T175146 JobQueue: Unify JobRunner entry points
		Resolved		• Clarakosi	T244826 Create rest endpoint for executing jobs instead of /rpc/RunSingleJob
		Resolved		• Pchelolo	T246156 Convert JobRunner into a service class
		Resolved		Umherirrender	T246369 JobRunner - clean up deprecations

Event Timeline

• Pchelolo created this task.Feb 27 2020, 6:26 PM

• Pchelolo moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Feb 27 2020, 6:35 PM

WDoranWMF moved this task from Backlog to Inbox on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:21 PM

• Pchelolo moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:29 PM

Krinkle removed a project: WMF-JobQueue.Mar 6 2020, 11:07 PM

• Pchelolo triaged this task as Low priority.Mar 24 2020, 8:46 PM

• Pchelolo added a project: Technical-Debt (Deprecation process).

• Pchelolo moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Apr 16 2020, 9:46 PM

• Pchelolo removed a project: Platform Team Workboards (Clinic Duty Team).

Removing inactive assignee (Platform Engineering: Please unassign tasks of previous team members.)

Already hard-deprecated - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/793840

No usage of the constructor - https://codesearch.wmcloud.org/search/?q=%5Cbnew%5Cs%2B%5C%5C%3FJobRunner%5Cb&i=nope&files=&excludeFiles=&repos=

the setLogger was directly hard deprecated, finding usage with codesearch is not easy.

Would say it is possible to require the arguments and adding @internal to the constructor

Change 869838 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] jobqueue: Remove JobRunner::setLogger and make constructor internal

https://gerrit.wikimedia.org/r/869838

gerritbot added a project: Patch-For-Review.Dec 20 2022, 7:03 PM

Change 869838 merged by jenkins-bot:

[mediawiki/core@master] jobqueue: Remove JobRunner::setLogger and make constructor internal

https://gerrit.wikimedia.org/r/869838

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2022, 6:31 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 21 2022, 7:01 AM

Umherirrender closed this task as Resolved.Dec 21 2022, 4:51 PM

Umherirrender claimed this task.