Problem
In T245662 we started using SpecialCheckUser::addLogEntry() from SpecialInvestigate::addLogEntries(). This was a quick way to get the log entries added, but added a bit of Technical-Debt that should be fixed at some point.
Proposed Solution
Move the method to a new service that can be used by both special pages.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dreamy_Jazz | T247789 Abstract SpecialCheckUser::addLogEntry() | |||
| Resolved | Tchanders | T245662 CU 2.0: Logging for Special:Investigate - Adding the data | |||
| Resolved | dmaza | T247024 CU 2.0: Logging for Special:Investigate - Displaying the data | |||
| Resolved | dmaza | T247516 CU 2.0: Logging for Special:Investigate - Page links |
Change 580123 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CheckUser@master] Separate out SpecialCheckUser::addLogEntry
@dbarratt alternative solution, since its also used in the checkuser api: move it to a trait. See the patch
Oh that's true. The trait works. I suppose even a static class would be fine.
Since T222388, API modules can have services injected into them. :)
Change 814297 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Move the function to log a check into a new CheckUserLogService
Change 580123 abandoned by Dreamy Jazz:
[mediawiki/extensions/CheckUser@master] Separate out SpecialCheckUser::addLogEntry
Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/814297 merged instead of this.
Change 814297 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move the function to log a check into a new CheckUserLogService