Remove use of ParsoidBatchAPI from Parsoid/PHP
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Mar 23 2020, 6:44 PM

Description

When we implemented Parsoid/PHP, we supported only API access using the ParsoidBatchAPI, *not* the legacy support for the "normal" API. This was a mistake, as we'd like to deprecate and remove ParsoidBatchAPI from the production cluster (T242430: Undeploy ParsoidBatchAPI from the Wikimedia cluster).

We need to convert our API access in Parsoid/PHP back to the "normal" API and remove code which assumes ParsoidBatchAPI.

This may involve fixing some core APIs, since ParsoidBatchAPI was papering over some issues (see T237754), but maybe those have already been fixed or are "good enough".

Details

	Subject	Repo	Branch	Lines +/-
	Replace use of ParsoidBatchAPI in Api/DataAccess.php	mediawiki/services/parsoid	master	+125 -129

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Jdforrester-WMF	T242430 Undeploy ParsoidBatchAPI from the Wikimedia cluster
Resolved	Goal	MarkAHershberger	T248186 Prepare Parsoid for MediaWiki 1.35 LTS
Resolved		ssastry	T248340 Remove use of ParsoidBatchAPI from Parsoid/PHP

Event Timeline

cscott created this task.Mar 23 2020, 6:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2020, 6:44 PM

cscott added a parent task: T242430: Undeploy ParsoidBatchAPI from the Wikimedia cluster.Mar 23 2020, 6:44 PM

cscott added a parent task: T248186: Prepare Parsoid for MediaWiki 1.35 LTS.

cscott mentioned this in T237754: Adjust TimedMedia url handling (getAPIData) to match legacy parser.

I am going to say: let us go with "good enough" since this feature is primarily for local testing -- and on large pages, this feature is mostly unusable since all API requests get serialized unlike Parsoid/JS. RT testing and beta testing is always our authoritative source of testing.

So, all that needs to happen is replace use of batch api with normal api when we operate Parsoid/PHP in this mode.

ssastry triaged this task as Medium priority.Mar 24 2020, 4:30 AM

ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.

tobiaswiese subscribed.Apr 1 2020, 6:48 PM

Change 593789 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Replace use of ParsoidBatchAPI in Api/DataAccess.php

https://gerrit.wikimedia.org/r/593789

gerritbot added a project: Patch-For-Review.May 1 2020, 6:16 PM

alex-mashin subscribed.May 8 2020, 3:16 AM

Change 593789 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Replace use of ParsoidBatchAPI in Api/DataAccess.php

https://gerrit.wikimedia.org/r/593789

Maintenance_bot removed a project: Patch-For-Review.May 10 2020, 9:10 PM

ssastry closed this task as Resolved.May 11 2020, 8:29 PM

ssastry claimed this task.

ssastry mentioned this in T242430: Undeploy ParsoidBatchAPI from the Wikimedia cluster.May 11 2020, 8:31 PM