Page MenuHomePhabricator

Remove use of ParsoidBatchAPI from Parsoid/PHP
Closed, ResolvedPublic


When we implemented Parsoid/PHP, we supported only API access using the ParsoidBatchAPI, *not* the legacy support for the "normal" API. This was a mistake, as we'd like to deprecate and remove ParsoidBatchAPI from the production cluster (T242430: Undeploy ParsoidBatchAPI from the Wikimedia cluster).

We need to convert our API access in Parsoid/PHP back to the "normal" API and remove code which assumes ParsoidBatchAPI.

This may involve fixing some core APIs, since ParsoidBatchAPI was papering over some issues (see T237754), but maybe those have already been fixed or are "good enough".

Event Timeline

I am going to say: let us go with "good enough" since this feature is primarily for local testing -- and on large pages, this feature is mostly unusable since all API requests get serialized unlike Parsoid/JS. RT testing and beta testing is always our authoritative source of testing.

So, all that needs to happen is replace use of batch api with normal api when we operate Parsoid/PHP in this mode.

ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.

Change 593789 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Replace use of ParsoidBatchAPI in Api/DataAccess.php

Change 593789 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Replace use of ParsoidBatchAPI in Api/DataAccess.php

ssastry claimed this task.